Rollup of PRs in the queue; Thursday #23502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stabilizes the `cloned` iterator after tweaking the signature to require that the iterator is over `&T` instead of `U: Deref<T>`. This method has had time to bake for awhile now and it's not clear whether the `Deref` bound is worth it. Additionally, there aren't clear conventions on when to bound and/or implement the `Deref` trait, so for now the conservative route is to require references instead of `U: Deref<T>`. To change this signature to using `Deref` would technically be a backwards-incompatible change, but it is doubtful that any code will actually break in practice.
Nothing inside of the read/write interface itself can panic, so any poison must have been the result of user code which the lock isn't protecting.
- remove `pub` from `struct` (visibility has no effect inside functions) - move `pthread_main_np` into function
[breaking-change]: instead of a closure like `|| -> i32 22`, prefer `||
-> i32 { 22 }`.
Fixes rust-lang#23420.
|
@bors: r+ p=10 |
|
📌 Commit 744cbc1 has been approved by |
|
⌛ Testing commit 744cbc1 with merge 365f280... |
…chton Hopefully didn’t miss or mess up anything. ~~EDIT: ah, as usual, just didn’t bother running build before pushing a submit request button. Build pending.~~
…uron This commit stabilizes the `cloned` iterator after tweaking the signature to require that the iterator is over `&T` instead of `U: Deref<T>`. This method has had time to bake for awhile now and it's not clear whether the `Deref` bound is worth it. Additionally, there aren't clear conventions on when to bound and/or implement the `Deref` trait, so for now the conservative route is to require references instead of `U: Deref<T>`. To change this signature to using `Deref` would technically be a backwards-incompatible change, but it is doubtful that any code will actually break in practice.
Nothing inside of the read/write interface itself can panic, so any poison must have been the result of user code which the lock isn't protecting. This seems safe to me, but if we don't want to go this route we should update the docs to indicate that these methods can panic. r? @alexcrichton
Typo
This is a significant performance problem in Servo.
|
💔 Test failed - auto-win-32-opt |
|
@bors: r+ force |
|
📌 Commit 5f5bc4c has been approved by |
|
⌛ Testing commit 5f5bc4c with merge bfa28c7... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: r+ force |
|
📌 Commit 6f930b9 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 19, 2015
…acrichto
Require braces when a closure has an explicit return type. This is a [breaking-change]: instead of a closure like `|| -> i32 22`, prefer `|| -> i32 { 22 }`.
Fixes rust-lang#23420.
…hton unbreak openbsd/bitrig build - remove `pub` from `struct` (error: visibility has no effect inside functions) - move `pthread_main_np` into function r? @alexcrichton
Update documentation to reflect rust-lang#21824. r? @steveklabnik
And do some formatting while I'm here.
This is a significant performance problem in Servo. r? @brson
Fixes rust-lang#22309 I am pretty sure that this is the right way to do this, given the other macros, but I'm not 100% sure.
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.