Require braces when a closure has an explicit return type. #23475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ d72a7d5 |
|
@bors r- |
|
I see local compilation failures. I'll have a fully fixed branch shortly. |
nikomatsakis
force-pushed
the
closure-ret-syntax
branch
from
d72a7d5 to
1115087
Compare
|
@bors r+ 1115087 |
[breaking-change]: instead of a closure like `|| -> i32 22`, prefer `||
-> i32 { 22 }`.
Fixes rust-lang#23420.
nikomatsakis
force-pushed
the
closure-ret-syntax
branch
from
1115087 to
c225824
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 19, 2015
…acrichto
Require braces when a closure has an explicit return type. This is a [breaking-change]: instead of a closure like `|| -> i32 22`, prefer `|| -> i32 { 22 }`.
Fixes rust-lang#23420.
|
This change is fascinating! It is also amusing that the changed code didn't use the explicit braces previously. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require braces when a closure has an explicit return type. This is a [breaking-change]: instead of a closure like
|| -> i32 22, prefer|| -> i32 { 22 }.Fixes #23420.