Repository navigation
revisions for TAIT in env bug - #163894
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
otherwise these won't ICE
lqd
approved these changes
Oct 7, 2026
| } | ||
| } | ||
|
|
||
| // FIXME(trait-system-refactor-initiative#293): This currently causes an ICE. |
Member
There was a problem hiding this comment.
this feels like a //@[next] known-bug: trait-system-refactor-initiative#293?
Contributor
Author
There was a problem hiding this comment.
yeah, we do have other //@[next] known-bug: trait-system-refactor-initiative#293 tests already and moving this into a separate file only to move it back when fixing that feels more annoying. Actually checked out this branch to do that rn but it just doesn't feel worth it.
Contributor
Author
|
@bors r=lqd rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 7, 2026
revisions for TAIT in env bug cc rust-lang/trait-system-refactor-initiative#293 r? types
This was referenced Oct 7, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
…uwer Rollup of 16 pull requests Successful merges: - #163887 (Remove `NonOwner` variant from `AstOwner`) - #163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - #162156 (add IBM f128 type) - #163925 (Submodule update of rustc-perf) - #163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - #163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell) - #163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - #163894 (revisions for TAIT in env bug) - #163902 (Clean up Reference annotations that drifted) - #163905 (Remove redundant closure in bootstrap) - #163921 (abby DSL: implement ambiguity) - #163927 (abby DSL: change `where` syntax to `predicates`) - #163933 (Add `synchronization` import lib to windows-gnullvm dist) - #163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Rollup merge of #163894 - lcnr:tait-in-env-bug, r=lqd revisions for TAIT in env bug cc rust-lang/trait-system-refactor-initiative#293 r? types
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Oct 8, 2026
…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`) - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - rust-lang/rust#162156 (add IBM f128 type) - rust-lang/rust#163925 (Submodule update of rustc-perf) - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize) - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell) - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - rust-lang/rust#163894 (revisions for TAIT in env bug) - rust-lang/rust#163902 (Clean up Reference annotations that drifted) - rust-lang/rust#163905 (Remove redundant closure in bootstrap) - rust-lang/rust#163921 (abby DSL: implement ambiguity) - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`) - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist) - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Oct 8, 2026
…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`) - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - rust-lang/rust#162156 (add IBM f128 type) - rust-lang/rust#163925 (Submodule update of rustc-perf) - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize) - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell) - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - rust-lang/rust#163894 (revisions for TAIT in env bug) - rust-lang/rust#163902 (Clean up Reference annotations that drifted) - rust-lang/rust#163905 (Remove redundant closure in bootstrap) - rust-lang/rust#163921 (abby DSL: implement ambiguity) - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`) - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist) - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Oct 9, 2026
…uwer Rollup of 16 pull requests Successful merges: - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`) - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` ) - rust-lang/rust#162156 (add IBM f128 type) - rust-lang/rust#163925 (Submodule update of rustc-perf) - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead) - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN) - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize) - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell) - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`) - rust-lang/rust#163894 (revisions for TAIT in env bug) - rust-lang/rust#163902 (Clean up Reference annotations that drifted) - rust-lang/rust#163905 (Remove redundant closure in bootstrap) - rust-lang/rust#163921 (abby DSL: implement ambiguity) - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`) - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist) - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars) > [!WARNING] > This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc rust-lang/trait-system-refactor-initiative#293
r? types