Skip to content

add IBM f128 type - #162156

Merged
rust-bors[bot] merged 5 commits into
rust-lang:mainfrom
folkertdev:ppcf128
Oct 7, 2026
Merged

add IBM f128 type#162156
rust-bors[bot] merged 5 commits into
rust-lang:mainfrom
folkertdev:ppcf128

Conversation

@folkertdev

@folkertdev folkertdev commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

View all comments

tracking issue: #161787
tracking issue: #163323

aka __ibm128, ppc_fp128, etc. Making this change without having settled on a final name is a bit awkward but hopefully we can get some rounds of review in anyway.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 1, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Sep 2, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev force-pushed the ppcf128 branch 3 times, most recently from fbe3899 to 66d3dfb Compare September 21, 2026 18:29
@folkertdev folkertdev added the F-c_longdouble `#![feature(c_longdouble)]` label Sep 21, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@folkertdev
folkertdev force-pushed the ppcf128 branch 2 times, most recently from d0e13f1 to 9251025 Compare September 21, 2026 22:01
folkertdev
folkertdev commented Sep 21, 2026
View reviewed changes
Comment thread library/stdarch/crates/core_arch/src/powerpc/mod.rs Outdated
Comment thread library/stdarch/crates/core_arch/src/powerpc/mod.rs
Comment thread compiler/rustc_abi/src/callconv/reg.rs Outdated
@folkertdev

folkertdev commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

r? tgross35

@folkertdev

folkertdev commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Rust for Linux disables float formatting (for code size reasons I believe), and so this Display impl (of what is basically a float) needs to be similarly cfg'd out. I missed that on f16b but it makes sense.

Let's see if that fix fixes everything

@bors try cancel

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run @bors try and bors will cancel the previous build automatically.

@folkertdev

folkertdev commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

ah, good to know, anyway

@bors try jobs=test-x86_64-rust-for-linux

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Auto merge of #162156 - folkertdev:ppcf128, r=<try>
f0f729d 
add IBM f128 type


try-job: test-x86_64-rust-for-linux
beetrees
beetrees reviewed Oct 7, 2026
View reviewed changes
Comment thread library/stdarch/crates/core_arch/src/powerpc/mod.rs Outdated
@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f0f729d (f0f729dd98af9cd32b7dc66bef81fd7fa3dbf744)
Base parent: 8d1a764 (8d1a76430406c877b35d0b627e7f796dcf0dfeca)

@folkertdev

folkertdev commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-x86_64-rust-for-linux

rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Auto merge of #162156 - folkertdev:ppcf128, r=<try>
cf687ed 
add IBM f128 type


try-job: test-x86_64-rust-for-linux
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: cf687ed (cf687edfa438710339280aa99858314aa402ecb7)
Base parent: 8d1a764 (8d1a76430406c877b35d0b627e7f796dcf0dfeca)

@folkertdev

folkertdev commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=beetrees,tgross35

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1a72a5a has been tentatively approved by beetrees,tgross35

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 7, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
1d81eb4 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #163887 (Remove `NonOwner` variant from `AstOwner`)
 - #163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - #162156 (add IBM f128 type)
 - #163925 (Submodule update of rustc-perf)
 - #163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - #163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - #163874 (explicitly check for fresh vars in canonicalize)
 - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - #163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - #163894 (revisions for TAIT in env bug)
 - #163902 (Clean up Reference annotations that drifted)
 - #163905 (Remove redundant closure in bootstrap)
 - #163921 (abby DSL: implement ambiguity)
 - #163927 (abby DSL: change `where` syntax to `predicates`)
 - #163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - #163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
@rust-bors
rust-bors Bot merged commit ac7df61 into rust-lang:main Oct 7, 2026
15 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Unrolled build for #162156 in rollup 163945
55cbd34 
Rollup merge of #162156 - folkertdev:ppcf128, r=beetrees,tgross35

add IBM f128 type

tracking issue: #161787
tracking issue: #163323

aka `__ibm128`, `ppc_fp128`, etc. Making this change without having settled on a final name is a bit awkward but hopefully we can get some rounds of review in anyway.
github-actions Bot pushed a commit to rust-lang/stdarch that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
4a6bf8e 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
@folkertdev folkertdev mentioned this pull request Oct 8, 2026
Open
8 tasks
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
8002d19 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Oct 9, 2026
@bors
Auto merge of #163945 - JonathanBrouwer:rollup-1F2ngED, r=JonathanBro…
69596b6 
…uwer

Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#163887 (Remove `NonOwner` variant from `AstOwner`)
 - rust-lang/rust#163892 (add revisions for `pass -> [err|ICE]` ui tests `-Znext-solver` )
 - rust-lang/rust#162156 (add IBM f128 type)
 - rust-lang/rust#163925 (Submodule update of rustc-perf)
 - rust-lang/rust#163658 ([PAC] Stop hard coding key and discriminator, consult schema instead)
 - rust-lang/rust#163854 (Include offset in the alignment check when creating ConstValue::Indirect in GVN)
 - rust-lang/rust#163874 (explicitly check for fresh vars in canonicalize)
 - rust-lang/rust#163880 (Don't add pkgs.rustc to PATH in nix dev shell)
 - rust-lang/rust#163893 (Panic on `StableHash` of a `Path` with `GenericArgs`)
 - rust-lang/rust#163894 (revisions for TAIT in env bug)
 - rust-lang/rust#163902 (Clean up Reference annotations that drifted)
 - rust-lang/rust#163905 (Remove redundant closure in bootstrap)
 - rust-lang/rust#163921 (abby DSL: implement ambiguity)
 - rust-lang/rust#163927 (abby DSL: change `where` syntax to `predicates`)
 - rust-lang/rust#163933 (Add `synchronization` import lib to windows-gnullvm dist)
 - rust-lang/rust#163937 (Abby test DSL: dont ICE on foralls with unused bound vars)

> [!WARNING]
> This rollup conflicts with pending auto build #163934 and may need to be recreated if the pending build succeeds.
feliperodri added a commit to feliperodri/kani that referenced this pull request Oct 11, 2026
@feliperodri
Upgrade the Rust toolchain to nightly-2026-10-11
773a30f 
- `loop_hint_attrs` moved from `mir::Terminator` into
  `TerminatorKind::Goto` (rust-lang/rust#163931).
- `rustc_abi::Float` gained `PpcF128` (rust-lang/rust#162156), PowerPC's
  double-double `long double`. It only exists on PowerPC targets, which
  Kani doesn't support, so report it as unsupported like `F16B`.
- rustc's diagnostic for `ui/ice-size-overflow` now also prints the
  enclosing `SizedTypeProperties` trait line; update the expected output.
@feliperodri feliperodri mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments
@beetrees beetrees beetrees approved these changes
@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` F-c_longdouble `#![feature(c_longdouble)]` PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

7 participants

@folkertdev @rust-log-analyzer @rustbot @tgross35 @JonathanBrouwer @RalfJung @beetrees