Rollup of 9 pull requests by matthiaskrgr · Pull Request #152484 · rust-lang/rust

matthiaskrgr · 2026-02-11T12:48:53Z

Successful merges:

Move more query system code #152419 (Move more query system code)
Restrict the set of things that const stability can be applied to #152431 (Restrict the set of things that const stability can be applied to)
Reenable a GCI+mGCA+GCPT test case #152436 (Reenable a GCI+mGCA+GCPT test case)
Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2 #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2)
mGCA: Add associated const type check #152146 (mGCA: Add associated const type check)
style: remove unneeded trailing commas #152372 (style: remove unneeded trailing commas)
BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable)
Update books #152397 (Update books)
Fix typos and grammar in top-level and src/doc documentation #152441 (Fix typos and grammar in top-level and src/doc documentation)

Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.

…e observed on stable

Keys and values now must be `Copy` due to erasing.

The derived version is equivalent to the hand-written version.

The latter is a new module. As well as the code motion, some other changes were required. - `QueryJobId` methods became free functions so they could move while `QueryJobId` itself stayed put. This was so `QueryMap` and `QueryJobInfo` could be moved. - Some visibilities in `rustc_query_system` required changing. - `collect_active_jobs_from_all_queries` is no longer required in `trait QueryContext`.

Because all uses are now in `rustc_query_impl`. This was made possible by the previous commit. Less code in `rustc_middle`, hooray.

From `rustc_query_system::query::job` to `rustc_query_impl::job`.

…rmal attribute logic instead of special cased checks

- CONTRIBUTING.md: add missing verb "is" - INSTALL.md: fix subject-verb agreement ("requires" → "require") - RELEASES.md: fix 4 issues (previous → previously, remove extra "is", add hyphen in Rust-for-Linux, results → result) - src/doc/not_found.md: fix misspelling ("Standary" → "Standard") - src/doc/index.md: fix awkward grammar in Embedded Rust Book description

@Zalathar

…ode, r=Zalathar Move more query system code Towards the goal of eliminating `rustc_query_system`, this commit moves some code from `rustc_query_system` to `rustc_middle` and `rustc_query_impl`, and from `rustc_middle` to `rustc_query_impl`. r? @Zalathar

@jdonszelmann

…jdonszelmann Restrict the set of things that const stability can be applied to r? @jdonszelmann

…ati865 Reenable a GCI+mGCA+GCPT test case The GCI+mGCA+GCPT test case can now be made to work with the necessary features and tweaks.

…-2, r=shepmaster Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2 Promote the following targets to Tier 2 without host tools: - `aarch64-apple-tvos`. - `aarch64-apple-tvos-sim`. - `aarch64-apple-watchos`. - `aarch64-apple-watchos-sim`. - `aarch64-apple-visionos`. - `aarch64-apple-visionos-sim`. This implements MCP rust-lang/compiler-team#918. Fixes rust-lang#151705. r? shepmaster

…s-wfck, r=BoxyUwU mGCA: Add associated const type check rust-lang#151642 r? BoxyUwU I didn't bless tests just yet as it only fixes the dyn arm

…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.

… r=TaKO8Ki BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable Not sure if that's worth it, maybe this goes without saying for all these builtin traits?

Update books ## rust-lang/book 1 commits in 39aeceaa3aeab845bc4517e7a44e48727d3b9dbe..05d114287b7d6f6c9253d5242540f00fbd6172ab 2026-02-03 15:19:04 UTC to 2026-02-03 15:19:04 UTC - Temporarily remove the link to `Drop::drop` (rust-lang/book#4576) ## rust-lang/nomicon 1 commits in 050c002a360fa45b701ea34feed7a860dc8a41bf..b8f254a991b8b7e8f704527f0d4f343a4697dfa9 2026-01-29 12:15:01 UTC to 2026-01-29 12:15:01 UTC - Fix deprecation warning for compare_and_swap in atomics.md (rust-lang/nomicon#519) ## rust-lang/reference 12 commits in 990819b86c22bbf538c0526f0287670f3dc1a67a..addd0602c819b6526b9cc97653b0fadca395528c 2026-02-04 14:35:59 UTC to 2026-01-26 18:02:14 UTC - const-eval.const-expr.field: make paragraph more clear (rust-lang/reference#2157) - make more clear what the link target is (rust-lang/reference#2156) - Update two URLs (rust-lang/reference#2154) - Add a chapter on divergence (rust-lang/reference#2067) - Guarantee `repr(C)` union field offset (rust-lang/reference#2128) - Reference updates for forbidding object lifetime changing pointer casts (rust-lang/reference#1951) - Clarify only arrays undergo unsized coercion during dispatch (rust-lang/reference#2139) - Split the textual chapter into separate char and str chapters (rust-lang/reference#2145) - Document ppc inline asm support (rust-lang/reference#2056) - Unwrap items, expressions, patterns, and types (rust-lang/reference#2141) - undefined behavior: add missing plural in `undefined.misaligned.ptr` (rust-lang/reference#2146) - inline-assembly: add a space to the `asm.abi-clobbers.many` example (rust-lang/reference#2144)

Fix typos and grammar in top-level and src/doc documentation Fix contextual typos and grammar issues in top-level and src/doc documentation that automated spellcheckers miss: - `CONTRIBUTING.md`: add missing verb "is" - `INSTALL.md`: fix subject-verb agreement ("requires" → "require") - `RELEASES.md`: fix 4 issues (previous → previously, remove extra "is", add hyphen in Rust-for-Linux, results → result) - `src/doc/not_found.md`: fix misspelling ("Standary" → "Standard") - `src/doc/index.md`: fix awkward grammar in Embedded Rust Book description No functional changes.

matthiaskrgr · 2026-02-11T12:49:33Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-11T12:49:36Z

📌 Commit f195663 has been approved by matthiaskrgr

It is now in the queue for this repository.

JonathanBrouwer · 2026-02-11T14:00:33Z

Since this rollup is third in queue at the moment anyways, does it make sense to remake it with all rollupable PRs in queue and run the try jobs again?

matthiaskrgr · 2026-02-11T14:40:13Z

I don't see how this makes sense.
try jobs already passed #152475 (comment)

JonathanBrouwer · 2026-02-11T14:44:53Z

So we can include more PRs in the rollup, if you don't want that it's fine tho

matthiaskrgr · 2026-02-11T14:53:04Z

how would this be helping?

JonathanBrouwer · 2026-02-11T14:56:53Z

It would empty the queue quicker

matthiaskrgr · 2026-02-11T15:21:20Z

It's actually the opposite. You will add more failures on top, which will actually have the opposite effect of maximizing time to merged.
You can easily see this on your own rollups: of your 200 rollups only 75 were merged (37%).
Looks like most of the time when you are doing rollups, the queue is actually growing instead of getting smaller?

JonathanBrouwer · 2026-02-11T15:41:40Z

I think the high closed rollups rate is because a lot of the time I close and remake rollups to add a few more PRs in, before they even start running, not a lot of them actually fail. Every "broken" PR in the queue will cause a failure at some point, so making a bigger rollup only moves the failures forwards, it does not add more failures

JonathanBrouwer · 2026-02-11T15:42:03Z

I don't really feel like argueing about optimal rollup strategy tho, just wanted to make a suggestion, so I'll just let you do your thing :)

matthiaskrgr · 2026-02-11T15:46:03Z

so making a bigger rollup only moves the failures forwards,

exactly, it moves the failures forward means it moves the merge (shrinking of the queue) backwards which causes the queue to grow and everyone has to wait longer

JonathanBrouwer · 2026-02-11T15:52:09Z

Moving the failures forwards increases the throughput (amount of PRs merged per time) but sacrifices latency.
To be precise, my strategy may delay merging PRs at the start of the queue because rollups will fail more often, but will empty the queue quicker because throughput is higher. People at the start of the queue wait longer, so people later in the queue don't have to wait as long. I theorize that the average waiting time would also be lower, tho I haven't calculated that.
I think this is worth it, but that's subjective, the classic throughput vs latency tradeoff in CS

rust-bors · 2026-02-12T03:44:13Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 5h 36m 43s
Pushing 5fdff78 to main...

rust-timer · 2026-02-12T03:46:47Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#152021	Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2	`80541af5d443d72498251f06d12f98c4d67ef375` (link)
#152146	mGCA: Add associated const type check	`a6fd87567a8b62b8de48e0fd15f4e3d46f0faf68` (link)
#152372	style: remove unneeded trailing commas	`8d1dfe0bd846da4a5b207828632f98239381fcde` (link)
#152383	BikeshedGuaranteedNoDrop trait: add comments indicating tha…	`c92661c4305cd02a2cc7fec55e129be0d8d50964` (link)
#152397	Update books	`5e63d3c1d8d6293106b044b63f20117345898776` (link)
#152419	Move more query system code	`c7f9582e3db326a94c30dcc988c2f3225a3ce0f3` (link)
#152431	Restrict the set of things that const stability can be appl…	`f797190c49a27253b6bfd2aa134acd0e41ea28fc` (link)
#152436	Reenable a GCI+mGCA+GCPT test case	`7840da4d521a602825133b932b7e35ef0d2d9057` (link)
#152441	Fix typos and grammar in top-level and src/doc documentation	`62c95040715a8b1f86eade837ca99c1ce12b8057` (link)

previous master: 7057231bd7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-02-12T03:47:31Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7057231 (parent) -> 5fdff78 (this PR)

Test differences

Show 28 test diffs

Stage 1

[ui] tests/ui/const-generics/associated-const-bindings/dyn-const-projection-escaping-bound-vars.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-1.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-2.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-3.rs: [missing] -> pass (J1)

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
[ui] tests/ui/const-generics/associated-const-bindings/dyn-const-projection-escaping-bound-vars.rs: [missing] -> pass (J2)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-1.rs: [missing] -> pass (J2)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-2.rs: [missing] -> pass (J2)
[ui] tests/ui/const-generics/associated-const-bindings/wf-mismatch-3.rs: [missing] -> pass (J2)

Additionally, 19 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5fdff787e6ef7cd4458f81e69cbb4d2a39439a98 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 4h 18m -> 1h 39m (-61.4%)
dist-x86_64-apple: 5h 1m -> 2h 18m (-53.9%)
aarch64-apple: 3h 35m -> 5h 27m (+52.3%)
dist-arm-linux-musl: 3h 3m -> 1h 35m (-47.8%)
dist-x86_64-solaris: 2h 54m -> 1h 33m (-46.1%)
pr-check-1: 56m 8s -> 30m 49s (-45.1%)
dist-x86_64-illumos: 3h 6m -> 1h 42m (-44.7%)
dist-sparcv9-solaris: 2h 38m -> 1h 30m (-43.1%)
x86_64-gnu-debug: 3h 7m -> 1h 53m (-39.4%)
dist-android: 44m 55s -> 27m 21s (-39.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-12T04:26:48Z

Finished benchmarking commit (5fdff78): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[5.4%, 5.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-4.9%, -4.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-5.5%, -4.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.438s -> 476.59s (0.03%)
Artifact size: 397.88 MiB -> 397.90 MiB (0.01%)

nyurik and others added 27 commits February 8, 2026 22:01

style: remove unneeded trailing commas

1fa165d

Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.

BikeshedGuaranteedNoDrop trait: add comments indicating that it can b…

8c0a493

…e observed on stable

Update books

6546a98

Remove out-of-date comment.

e1ed3bf

Keys and values now must be `Copy` due to erasing.

Derive Clone for QueryLatch.

1c4661c

The derived version is equivalent to the hand-written version.

mGCA: add associated const type check in dyn arm

b6b6dc0

mGCA: add associated const obligations in wfck

963f82d

bless tests

ec03e39

Move rustc_middle::query::values to rustc_query_impl.

923de04

Because all uses are now in `rustc_query_impl`. This was made possible by the previous commit. Less code in `rustc_middle`, hooray.

Move report_cycle.

a34317e

From `rustc_query_system::query::job` to `rustc_query_impl::job`.

Remove accidental const stability marker on a struct

0ebd56e

Restrict the set of things that const stability can be applied

628c37a

Prevent const stability attrs from being applied to macros via the no…

475b9d9

…rmal attribute logic instead of special cased checks

Reenable a GCI+mGCA+GCPT test case

32e49a8

Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2

4a01f22

Disable profiler runtime on tvOS and watchOS

4fa388c

Rollup merge of rust-lang#152431 - oli-obk:limited_stability_attr, r=…

88eda64

…jdonszelmann Restrict the set of things that const stability can be applied to r? @jdonszelmann

Rollup merge of rust-lang#152436 - fmease:reenable-gci-test-case, r=m…

6c8bbfe

…ati865 Reenable a GCI+mGCA+GCPT test case The GCI+mGCA+GCPT test case can now be made to work with the necessary features and tweaks.

Rollup merge of rust-lang#152146 - zedddie:mgca-improve-const-binding…

9a4ce0b

…s-wfck, r=BoxyUwU mGCA: Add associated const type check rust-lang#151642 r? BoxyUwU I didn't bless tests just yet as it only fixes the dyn arm

Rollup merge of rust-lang#152383 - RalfJung:BikeshedGuaranteedNoDrop,…

336deba

… r=TaKO8Ki BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable Not sure if that's worth it, maybe this goes without saying for all these builtin traits?

rust-bors bot added the rollup A PR which is a rollup label Feb 11, 2026

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI labels Feb 11, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2026

rust-bors bot merged commit 5fdff78 into rust-lang:main Feb 12, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 12, 2026

rust-bors bot mentioned this pull request Feb 12, 2026

Change query proc macro to be more rust-analyzer friendly #152422

Open

This was referenced Feb 12, 2026

[EXPERIMENT] Rollup of 18 pull requests #152513

Open

Remove deterministic picking from query cycle handling #152229

Draft

Uh oh!

Conversation

matthiaskrgr commented Feb 11, 2026

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

rust-bors bot commented Feb 11, 2026

Uh oh!

JonathanBrouwer commented Feb 11, 2026

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

JonathanBrouwer commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

JonathanBrouwer commented Feb 11, 2026

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

JonathanBrouwer commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Feb 11, 2026

Uh oh!

JonathanBrouwer commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 12, 2026

Uh oh!

Uh oh!

rust-timer commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 12, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

JonathanBrouwer commented Feb 11, 2026 •

edited

Loading

JonathanBrouwer commented Feb 11, 2026 •

edited

Loading

JonathanBrouwer commented Feb 11, 2026 •

edited

Loading

JonathanBrouwer commented Feb 11, 2026 •

edited

Loading