style: remove unneeded trailing commas #152372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Should commas in the same module be removed in places like this? 🤔 |
Contributor
Author
|
@xizheyin that's a good question. The lint i wrote wouldn't catch these unless they have In this specific case, I think it is a good idea to remove that comma as it doesn't seem to have any impact. If it does, and both variants compile and pass tests, it would be a more significant problem - i.e. a comma becoming an important parameter to a "function-like" macro call is just wrong. |
Member
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…uwer Rollup of 13 pull requests Successful merges: - #149937 (try enabling `linker-messages` by default again) - #151733 (Use function shims to make sure EII works on apple targets) - #152120 (Don't ICE on layout error in vtable computation) - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #151142 (Support ADT types in type info reflection) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 10, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Rollup of 10 pull requests Successful merges: - #152120 (Don't ICE on layout error in vtable computation) - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2026
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
This was referenced Feb 11, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Rollup of 9 pull requests Successful merges: - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)
rust-timer
added a commit
that referenced
this pull request
Feb 12, 2026
Rollup merge of #152372 - nyurik:clippy-rustc_trait_selection, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make format-like macro calls look similar to what
cargo fmtdoes automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.I'm working on a clippy lint to make this process automatic.