Cleanup of #[derive(Diagnostic)] attribute parsers
#151657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
This comment has been minimized.
This comment has been minimized.
3 tasks
JonathanBrouwer
force-pushed
the
diag2
branch
from
9f11d3b to
e38bc5a
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
diag2
branch
from
e38bc5a to
2e8347a
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
cc @davidtwco, @TaKO8Ki |
rustbot
removed
the
S-waiting-on-author
Member
hm, do we still need this notification?
yep, i think so too
i'll take a closer look tomorrow, but i'm pretty sure that's all fine <3 |
Contributor
Author
Afaik these notifications are for people who want to know if certain directories change, whether it is needed is mostly for them to decide. There is no further expectations such as waiting for their review. Actually just added myself to the list, cause I'm now also interested in changes of these files #151800 |
Member
oh, that's nice, thanks for keeping an eye on it |
Member
|
ok, nice, thanks for working on it! @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2026
Rollup of 5 pull requests Successful merges: - #151775 (Portable SIMD subtree update) - #151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - #149823 (fix(parser): Disallow CR in frontmatter ) - #151475 (add foregin type tests for issue 64458) - #151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
rust-timer
added a commit
that referenced
this pull request
Jan 29, 2026
Rollup merge of #151657 - JonathanBrouwer:diag2, r=Kivooeo Cleanup of `#[derive(Diagnostic)]` attribute parsers This PR does a lot of refactoring on the implementation of `#[derive(Diagnostic)]`. It should have no observable effect other than error messages for incorrect usage of the attributes. In general, I think the error messages got better. This PR can be reviewed commit by commit, each commit passes the tests. - [Convert parse_nested_meta to parse_args_with for #[diagnostic]](9e61014) Start parsing `#[diagnostic]` using `syn`'s `parse_args_with` function instead of `parse_nested_meta`. This improves error messages and prepares for the new syntax needed for #151366 which cannot be parsed using `parse_args_with`. - [Convert parse_nested_meta to parse_args_with for #[subdiagnostic]](5d21a21) Same as above but for `#[subdiagnostic]` - [Remove unused no_span option](0bf3f5d) Removes the `no_span` option of `#[suggestion]`, which there were no tests for and which seems to have been unused. If needed again in the future, this can be re-added pretty easily, but I find that unlikely. - [Remove HasFieldMap trait in favour of passing FieldMap directly](2e8347a) Removes the `HasFieldMap` trait, because I don't really see the point of having a trait "has a field map" if we can just pass the fieldmap itself instead. r? @Kivooeo (Thanks for reviewing my PRs so far :3)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 30, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#151775 (Portable SIMD subtree update) - rust-lang/rust#151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - rust-lang/rust#149823 (fix(parser): Disallow CR in frontmatter ) - rust-lang/rust#151475 (add foregin type tests for issue 64458) - rust-lang/rust#151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
Kobzol
pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#151775 (Portable SIMD subtree update) - rust-lang/rust#151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - rust-lang/rust#149823 (fix(parser): Disallow CR in frontmatter ) - rust-lang/rust#151475 (add foregin type tests for issue 64458) - rust-lang/rust#151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
Kobzol
pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#151775 (Portable SIMD subtree update) - rust-lang/rust#151488 (Tweak E0599 to consolidate unsatisfied trait bound messages) - rust-lang/rust#149823 (fix(parser): Disallow CR in frontmatter ) - rust-lang/rust#151475 (add foregin type tests for issue 64458) - rust-lang/rust#151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a lot of refactoring on the implementation of
#[derive(Diagnostic)]. It should have no observable effect other than error messages for incorrect usage of the attributes. In general, I think the error messages got better.This PR can be reviewed commit by commit, each commit passes the tests.
Start parsing
#[diagnostic]usingsyn'sparse_args_withfunction instead ofparse_nested_meta. This improves error messages and prepares for the new syntax needed for Tracking issue for MCP 959: Remove the fluent files #151366 which cannot be parsed usingparse_args_with.Same as above but for
#[subdiagnostic]Removes the
no_spanoption of#[suggestion], which there were no tests for and which seems to have been unused. If needed again in the future, this can be re-added pretty easily, but I find that unlikely.Removes the
HasFieldMaptrait, because I don't really see the point of having a trait "has a field map" if we can just pass the fieldmap itself instead.r? @Kivooeo
(Thanks for reviewing my PRs so far :3)