Skip to content

Conversation

@calebzulawski
Copy link
Member

calebzulawski and others added 30 commits January 18, 2025 15:37
The `#[must_use]` attribute has no effect when applied to methods in
trait implementations.
Remove usize/isize impls from
- `loongarch64.rs`
- `wasm32.rs`
- `x86.rs`
Remove usize/isize `From` impls for vendor vector types
Add const to `as_mut_array`, `copy_to_slice`
Update examples to remove features that have been stabilized
Update nightly toolchain and `Cargo.lock`, fix examples broken by stabilized features
loongarch64: Use unified data types for SIMD intrinsics
calebzulawski and others added 13 commits September 12, 2025 22:03
…tribute (rust-lang#485)

* Remove LaneCount in favor of #[rustc_simd_monomorphize_lane_limit] attribute

* Document allowed vector lengths
    warning: `#[must_use]` attribute cannot be used on trait methods in impl blocks
       --> crates/core_simd/src/masks/bitmask.rs:173:5
        |
    173 |     #[must_use = "method returns a new mask and does not mutate the original value"]
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        |
        = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
        = help: `#[must_use]` can be applied to data types, foreign functions, functions, inherent methods, provided trait methods, required trait methods, traits, and unions
        = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default

    warning: `#[must_use]` attribute cannot be used on trait methods in impl blocks
       --> crates/core_simd/src/masks/bitmask.rs:190:5
        |
    190 |     #[must_use = "method returns a new mask and does not mutate the original value"]
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        |
        = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
        = help: `#[must_use]` can be applied to data types, foreign functions, functions, inherent methods, provided trait methods, required trait methods, traits, and unions

    warning: `#[must_use]` attribute cannot be used on trait methods in impl blocks
       --> crates/core_simd/src/masks/bitmask.rs:206:5
        |
    206 |     #[must_use = "method returns a new mask and does not mutate the original value"]
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        |
        = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
        = help: `#[must_use]` can be applied to data types, foreign functions, functions, inherent methods, provided trait methods, required trait methods, traits, and unions

    warning: `#[must_use]` attribute cannot be used on trait methods in impl blocks
       --> crates/core_simd/src/masks/bitmask.rs:222:5
        |
    222 |     #[must_use = "method returns a new mask and does not mutate the original value"]
        |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        |
        = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
        = help: `#[must_use]` can be applied to data types, foreign functions, functions, inherent methods, provided trait methods, required trait methods, traits, and unions
use `cargo miri nextest` to parallelize miri tests
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @programmerjake

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@calebzulawski
Copy link
Member Author

⚠️ Warning ⚠️

* There are issue links (such as `#123`) in the commit messages of the following commits.
  _Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree._
  
  * [32ba8ed](https://github.com/rust-lang/rust/commit/32ba8edf03c233640569c1f9a0bf4529c3a6608c)
  * [8ce88bc](https://github.com/rust-lang/rust/commit/8ce88bcb509e1f7d7b6b76724a6fcb827d9a78ac)
  * [4215b72](https://github.com/rust-lang/rust/commit/4215b7228d28cb84016e8f0e41c0a5e0935a222f)

Maybe we can add this check to the portable SIMD repo to avoid this in the future... I can't fix the commits now in a subtree update.

@rust-log-analyzer

This comment has been minimized.

@calebzulawski calebzulawski force-pushed the sync-from-portable-simd-2026-01-28 branch from ea63684 to df7dede Compare January 28, 2026 05:58
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 28, 2026
@rust-log-analyzer

This comment has been minimized.

@calebzulawski calebzulawski force-pushed the sync-from-portable-simd-2026-01-28 branch from df7dede to db243a5 Compare January 28, 2026 22:35
@rust-log-analyzer

This comment has been minimized.

@calebzulawski calebzulawski force-pushed the sync-from-portable-simd-2026-01-28 branch from db243a5 to b71ff51 Compare January 28, 2026 23:35
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

The Miri subtree was changed

cc @rust-lang/miri

@calebzulawski
Copy link
Member Author

@RalfJung I had to update the miri tests in the last commit to match std::simd. This is fine and will sync back to miri, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.