Skip to content

Rollup of 2 pull requests#151646

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
matthiaskrgr:rollup-HPnXGA3
Jan 25, 2026
Merged

Rollup of 2 pull requests#151646
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
matthiaskrgr:rollup-HPnXGA3

Conversation

@matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost

Create a similar rollup

heiher and others added 4 commits January 20, 2026 16:26
On LoongArch targets, `-Cdirect-access-external-data` defaults to `no`.
Since copy relocations are not supported, `dso_local` is not emitted
under `-Crelocation-model=static`, unlike on other targets.
LoongArch: Fix direct-access-external-data test

On LoongArch targets, `-Cdirect-access-external-data` defaults to `no`. Since copy relocations are not supported, `dso_local` is not emitted under `-Crelocation-model=static`, unlike on other targets.
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Jan 25, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2026
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

📌 Commit 0de96f4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2026
@41116120010
Copy link

great!

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 13m 48s
Pushing 38c7129 to main...

@rust-bors rust-bors bot merged commit 38c7129 into rust-lang:main Jan 25, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 25, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#151404 LoongArch: Fix direct-access-external-data test 13a4a190e1b49520dbda7f6f97b91a00243f5985 (link)
#151405 LoongArch: Fix call-llvm-intrinsics test 02288172d4cc20548fc38b7fdce6d93d0554a8a3 (link)

previous master: 9415853279

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9415853 (parent) -> 38c7129 (this PR)

Test differences

Show 9 test diffs

Stage 1

  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#DEFAULT: [missing] -> ignore (only executed when the architecture is loongarch64) (J0)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#DIRECT: [missing] -> ignore (only executed when the architecture is loongarch64) (J0)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#INDIRECT: [missing] -> ignore (only executed when the architecture is loongarch64) (J0)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#PIE: [missing] -> ignore (only executed when the architecture is loongarch64) (J0)

Stage 2

  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#DEFAULT: [missing] -> ignore (only executed when the architecture is loongarch64) (J1)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#DIRECT: [missing] -> ignore (only executed when the architecture is loongarch64) (J1)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#INDIRECT: [missing] -> ignore (only executed when the architecture is loongarch64) (J1)
  • [codegen] tests/codegen-llvm/loongarch/direct-access-external-data.rs#PIE: [missing] -> ignore (only executed when the architecture is loongarch64) (J1)

Additionally, 1 doctest diff were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 38c71295e8cdc6f04511fd7a12b28f000b620994 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 8340.7s -> 6596.3s (-20.9%)
  2. dist-apple-various: 3965.3s -> 4766.0s (+20.2%)
  3. dist-i586-gnu-i586-i686-musl: 4922.4s -> 5499.9s (+11.7%)
  4. pr-check-1: 1472.9s -> 1634.0s (+10.9%)
  5. x86_64-rust-for-linux: 2717.5s -> 2429.6s (-10.6%)
  6. x86_64-gnu-aux: 7230.5s -> 7935.8s (+9.8%)
  7. x86_64-gnu-stable: 7392.1s -> 8067.5s (+9.1%)
  8. x86_64-gnu-llvm-21-2: 4937.2s -> 5386.3s (+9.1%)
  9. i686-gnu-nopt-1: 7949.1s -> 7263.3s (-8.6%)
  10. dist-powerpc64-linux-gnu: 5508.7s -> 5073.1s (-7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38c7129): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.3%, -0.0%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.2%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.3% [4.5%, 6.1%] 5
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.4% [-3.1%, -1.6%] 2
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

Results (primary 7.7%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
8.4% [0.9%, 16.7%] 14
Regressions ❌
(secondary)
4.3% [2.8%, 5.8%] 3
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
-4.3% [-4.5%, -4.2%] 2
All ❌✅ (primary) 7.7% [-2.0%, 16.7%] 15

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.507s -> 474.192s (0.78%)
Artifact size: 383.59 MiB -> 383.57 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants