Skip to content

LoongArch: Fix direct-access-external-data test #151404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 25, 2026
Merged

LoongArch: Fix direct-access-external-data test #151404

rust-bors merged 1 commit into from
Jan 25, 2026

Conversation

@heiher
Copy link
Contributor

@heiher heiher commented Jan 20, 2026

On LoongArch targets, -Cdirect-access-external-data defaults to no. Since copy relocations are not supported, dso_local is not emitted under -Crelocation-model=static, unlike on other targets.

@heiher
LoongArch: Fix direct-access-external-data test
e3f198e 
On LoongArch targets, `-Cdirect-access-external-data` defaults to `no`.
Since copy relocations are not supported, `dso_local` is not emitted
under `-Crelocation-model=static`, unlike on other targets.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 25, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

📌 Commit e3f198e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 25, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
@bors
Auto merge of #151646 - matthiaskrgr:rollup-HPnXGA3, r=matthiaskrgr
38c7129 
Rollup of 2 pull requests

Successful merges:

 - #151404 (LoongArch: Fix direct-access-external-data test)
 - #151405 (LoongArch: Fix call-llvm-intrinsics test)
@rust-bors rust-bors bot merged commit f6a8326 into rust-lang:main Jan 25, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 25, 2026
rust-timer added a commit that referenced this pull request Jan 25, 2026
@rust-timer
Unrolled build for #151404
13a4a19 
Rollup merge of #151404 - heiher:fix-dae, r=Mark-Simulacrum

LoongArch: Fix direct-access-external-data test

On LoongArch targets, `-Cdirect-access-external-data` defaults to `no`. Since copy relocations are not supported, `dso_local` is not emitted under `-Crelocation-model=static`, unlike on other targets.
@heiher heiher deleted the fix-dae branch February 4, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@heiher @rustbot @Mark-Simulacrum