Rollup of 6 pull requests - #151315
Closed
JonathanBrouwer wants to merge 15 commits into
Closed
Conversation
Allow invoking all help options at once Implements rust-lang#150442 Help messages are printed in the order they are invoked, but only once (e.g. `--help -C help --help` prints regular help then codegen help). Lint groups (`-Whelp`) are always printed last due to necessarily coming later in the compiler pipeline. Adds `help` flags to `-C` and `-Z` to avoid an error in `build_session_options`. cc @bjorn3 [#t-compiler/major changes > Allow combining &rust-lang#96;--help -C help -Z help -… compiler-team#954 @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/233931-t-compiler.2Fmajor-changes/topic/Allow.20combining.20.60--help.20-C.20help.20-Z.20help.20-.E2.80.A6.20compiler-team.23954/near/564358190) - this currently maintains the behaviour of unrecognized options always failing-fast, as this happens within `getopt`s parsing, before we can even check if help options are present.
Added mGCA related tests Add regression tests for subsequent mGCA tasks edit: resolve: rust-lang#147415 `tests\ui\const-generics\mgca\size-of-generic-ptr-in-array-len.rs` resolve: rust-lang#141014 `tests\ui\const-generics\mgca\assoc-const-projection-in-bound.rs` and crashes: 138226, 138226-2, 149809, 150960
Explicitly list crate level attrs r? @jdonszelmann
…, r=mati865 Fix ICE on inconsistent import resolution with macro-attributed extern crate Fixes rust-lang#151213 using issue_145575_hack_applied in the same way as in rust-lang#149860.
Normalize type_const items even with feature `generic_const_exprs` Fixes rust-lang#151251 With feature `generic_const_exprs` enabled, consts with `#[type_const]` won't be normalized even if they need. Then ICE happens when CTFE tries to evaluate such const without body. Fix this by normalizing such consts even with feature `generic_const_exprs` enabled. r? @BoxyUwU
Use `find_attr` instead of `attr::contains_name` in `lower_const_item_rhs` Fixes rust-lang#151250 `attr::contains_name` uses `AttributeExt::name()` to filter, but for `hir::Attribute::Parsed`, this method will return `None`, and then `attr::contains_name` will return `false` here. So that the previous logic cannot work as expected. r? @BoxyUwU
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
generic_const_exprs#151275 (Normalize type_const items even with featuregeneric_const_exprs)find_attrinstead ofattr::contains_nameinlower_const_item_rhs#151288 (Usefind_attrinstead ofattr::contains_nameinlower_const_item_rhs)r? @ghost
Create a similar rollup