Skip to content

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 7, 2026

Implements #150442

Help messages are printed in the order they are invoked, but only once (e.g. --help -C help --help prints regular help then codegen help).

Lint groups (-Whelp) are always printed last due to necessarily coming later in the compiler pipeline.

Adds help flags to -C and -Z to avoid an error in build_session_options.

cc @bjorn3 #t-compiler/major changes > Allow combining `--help -C help -Z help -… compiler-team#954 @ 💬 - this currently maintains the behaviour of unrecognized options always failing-fast, as this happens within getopts parsing, before we can even check if help options are present.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jyn514
Copy link
Member

jyn514 commented Jan 7, 2026

could you add some tests for this, please?

@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 7, 2026
@clubby789
Copy link
Contributor Author

Added tests for the new combined help behavior, as well as testing the current behavior of --help --invalid-flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants