Rollup of 12 pull requests #150830

matthiaskrgr · 2026-01-08T19:35:47Z

Successful merges:

tidy: add if-installed prefix condition to extra checks system #149961 (tidy: add if-installed prefix condition to extra checks system)
std: sys: fs: uefi: Implement initial File #150475 (std: sys: fs: uefi: Implement initial File)
std: sys: fs: uefi: Implement remove_dir_all #150533 (std: sys: fs: uefi: Implement remove_dir_all)
fix missing_panics_doc in std::os::fd::owned #150549 (fix missing_panics_doc in std::os::fd::owned)
MGCA: Support literals as direct const arguments #150699 (MGCA: Support literals as direct const arguments)
Deprecated doc intra link #150721 (Deprecated doc intra link)
Update libc to v0.2.180 #150752 (Update libc to v0.2.180)
Minor cleanups to fn_abi_new_uncached #150802 (Minor cleanups to fn_abi_new_uncached)
compiler-builtins subtree update #150803 (compiler-builtins subtree update)
Update literal-escaper version to 0.0.7 #150809 (Update literal-escaper version to 0.0.7)
Store defids instead of symbol names in the aliases list #150811 (Store defids instead of symbol names in the aliases list)
Query associated_item_def_ids when needed #150825 (Query associated_item_def_ids when needed)

Define a new function ensure_version which is extracted (and modified) from ensure_version_or_cargo_install.

for other extra checks, it is WIP.

This updates the rust-version file to 23d01cd.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 23d01cd Filtered ref: 5d28c73d267214190903896b4caf2e40a17a56cb Upstream diff: rust-lang/rust@2dc3024...23d01cd This merge was created using https://github.com/rust-lang/josh-sync.

…emove unsafe from usages" We can't drop the `unsafe` here because it is required at the `libm` MSRV. Instead, we will need to `allow` the lint. This reverts commit 96ac3624abc144db930d94504a9c67aad7b949ed.

- Implement basic opening and creating files. - Also implement debug. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

Make it easier to run the same steps outside of GitHub Actions.

- Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it. CC rust-lang#150725

This commit moves a query to `associated_item_defs` from above an error condition caused independently of it to below it. It looks generally cleaner and might potentially save some runtime in case the error condition is met, rendering `items` to be left unused, yet still queried.

…k, r=lolbinarycat tidy: add if-installed prefix condition to extra checks system Ref: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/543227610 tidy now runs spellcheck (typos-cli) without adding `--extra-checks=spellcheck` option if the tool is already installed under ./build/misc-tools and the version is expected. It will improve code quality without bothering engineers who doesn't want to use typos or who cleans up ./build directory frequently.

@rustbot

std: sys: fs: uefi: Implement initial File - Implement basic opening and creating files. - Also implement debug. @rustbot label +O-UEFI

Minor cleanups to fn_abi_new_uncached

@ghost

compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@65624df. Created using https://github.com/rust-lang/josh-sync. r? @ghost

@bjorn3

Update `literal-escaper` version to `0.0.7` It removes the `std` dependency for this crate (which doesn't change anything for rustc 😄 ). cc @bjorn3 r? @Urgau

@bjorn3

Store defids instead of symbol names in the aliases list I was honestly surprised this worked in the past. This causes a cycle error since we now compute a symbol name in codegen_attrs, and then compute codegen attrs when we try to get the symbol name. It only worked when there weren't any codegen attributes to begin with, causing symbol name computation to skip the call to codegen_attrs. Like this we won't have the same problem. r? @bjorn3

Query associated_item_def_ids when needed This commit moves a query to `associated_item_defs` from above an error condition caused independently of it to below it. It looks generally cleaner and might potentially save some runtime in case the error condition is met, rendering `items` to be left unused, yet still queried.

matthiaskrgr · 2026-01-08T19:41:54Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-08T19:41:59Z

📌 Commit a38e3d4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@ghost

Rollup of 12 pull requests Successful merges: - #149961 (tidy: add if-installed prefix condition to extra checks system) - #150475 (std: sys: fs: uefi: Implement initial File) - #150533 (std: sys: fs: uefi: Implement remove_dir_all) - #150549 (fix missing_panics_doc in `std::os::fd::owned`) - #150699 (MGCA: Support literals as direct const arguments) - #150721 (Deprecated doc intra link) - #150752 (Update libc to v0.2.180) - #150802 (Minor cleanups to fn_abi_new_uncached) - #150803 (compiler-builtins subtree update) - #150809 (Update `literal-escaper` version to `0.0.7`) - #150811 (Store defids instead of symbol names in the aliases list) - #150825 (Query associated_item_def_ids when needed) r? @ghost

rust-log-analyzer · 2026-01-08T20:21:36Z

The job dist-ohos-x86_64 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling addr2line v0.25.1
[RUSTC-TIMING] addr2line test:false 0.662
[RUSTC-TIMING] gimli test:false 4.170
[RUSTC-TIMING] object test:false 5.098
error[E0609]: no field `st_atime` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:370:30
    |
370 |         file_attr.as_inner().st_atime as i64
    |                              ^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
370 -         file_attr.as_inner().st_atime as i64
370 +         file_attr.as_inner().st_atim as i64
    |

error[E0609]: no field `st_atime_nsec` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:373:36
    |
373 |         self.as_inner().as_inner().st_atime_nsec as i64
    |                                    ^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `st_dev`, `st_ino`, `st_nlink`, `st_mode`, `st_uid` ... and 8 others

error[E0609]: no field `st_mtime` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:381:30
    |
381 |         file_attr.as_inner().st_mtime as i64
    |                              ^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
381 -         file_attr.as_inner().st_mtime as i64
381 +         file_attr.as_inner().st_mtim as i64
    |

error[E0609]: no field `st_mtime_nsec` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:384:36
    |
384 |         self.as_inner().as_inner().st_mtime_nsec as i64
    |                                    ^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `st_dev`, `st_ino`, `st_nlink`, `st_mode`, `st_uid` ... and 8 others

error[E0609]: no field `st_ctime` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:392:30
    |
392 |         file_attr.as_inner().st_ctime as i64
    |                              ^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
392 -         file_attr.as_inner().st_ctime as i64
392 +         file_attr.as_inner().st_ctim as i64
    |

error[E0609]: no field `st_ctime_nsec` on type `&libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/os/linux/fs.rs:395:36
    |
395 |         self.as_inner().as_inner().st_ctime_nsec as i64
    |                                    ^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `st_dev`, `st_ino`, `st_nlink`, `st_mode`, `st_uid` ... and 8 others

error[E0609]: no field `st_mtime` on type `libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/sys/fs/unix.rs:633:35
    |
633 |         SystemTime::new(self.stat.st_mtime as i64, self.stat.st_mtime_nsec as i64)
    |                                   ^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
633 -         SystemTime::new(self.stat.st_mtime as i64, self.stat.st_mtime_nsec as i64)
633 +         SystemTime::new(self.stat.st_mtim as i64, self.stat.st_mtime_nsec as i64)
    |

error[E0609]: no field `st_mtime_nsec` on type `libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/sys/fs/unix.rs:633:62
    |
633 |         SystemTime::new(self.stat.st_mtime as i64, self.stat.st_mtime_nsec as i64)
    |                                                              ^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `st_dev`, `st_ino`, `st_nlink`, `st_mode`, `st_uid` ... and 8 others

error[E0609]: no field `st_atime` on type `libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/sys/fs/unix.rs:668:35
    |
668 |         SystemTime::new(self.stat.st_atime as i64, self.stat.st_atime_nsec as i64)
    |                                   ^^^^^^^^ unknown field
    |
help: a field with a similar name exists
    |
668 -         SystemTime::new(self.stat.st_atime as i64, self.stat.st_atime_nsec as i64)
668 +         SystemTime::new(self.stat.st_atim as i64, self.stat.st_atime_nsec as i64)
    |

error[E0609]: no field `st_atime_nsec` on type `libc::stat`
   --> /rustc/c6f0428c34cdbc205cb5461edb1d6adb32a24aec/library/std/src/sys/fs/unix.rs:668:62
    |
668 |         SystemTime::new(self.stat.st_atime as i64, self.stat.st_atime_nsec as i64)
    |                                                              ^^^^^^^^^^^^^ unknown field
    |
    = note: available fields are: `st_dev`, `st_ino`, `st_nlink`, `st_mode`, `st_uid` ... and 8 others

For more information about this error, try `rustc --explain E0609`.
[RUSTC-TIMING] std test:false 3.549
error: could not compile `std` (lib) due to 10 previous errors
Bootstrap failed while executing `dist --host=x86_64-unknown-linux-ohos --target x86_64-unknown-linux-ohos`

rust-bors · 2026-01-08T20:22:37Z

💔 Test for c6f0428 failed: CI. Failed jobs:

auto - dist-ohos-x86_64 (web logs, enhanced plaintext logs)

Shunpoco and others added 30 commits December 25, 2025 12:15

Extract version check from ensure_version_or_cargo_install

9f7dc2e

Define a new function ensure_version which is extracted (and modified) from ensure_version_or_cargo_install.

implpement if_installed for spellcheck

b305a98

for other extra checks, it is WIP.

implement shellcheck

70d8c61

implement js check

258708f

implement py and cpp

5642a2d

Prepare for merging from rust-lang/rust

6da3605

This updates the rust-version file to 23d01cd.

compiler-builtins: Revert "cpuid is safe since the stdarch sync, so r…

380e4d2

…emove unsafe from usages" We can't drop the `unsafe` here because it is required at the `libm` MSRV. Instead, we will need to `allow` the lint. This reverts commit 96ac3624abc144db930d94504a9c67aad7b949ed.

Ignore unused_unsafe lint in libm/src/math/arch/x86/detect.rs

1276564

std: sys: fs: uefi: Implement initial File

2ac2b18

- Implement basic opening and creating files. - Also implement debug. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

fix typo (this commit will be squashed after review)

b49e56d

fix missing_panics_doc in std::os::fd::owned

215768a

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

address review

68ea14a

Fix a typo in libm::Libm::roundeven

0d366e0

ci: Move the dependency installs and wall time benchmarks to scripts

65639fe

Make it easier to run the same steps outside of GitHub Actions.

add unit test for ExtraCheckArg::from_str

08e0400

move ensure_version/ensure_version_or_cargo_install to extra_checks

dfe7d8a

std: sys: fs: uefi: Implement remove_dir_all

3f773fa

- Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

address reviews

0dfff23

compiler-builtins: Enable AArch64 __chkstk for MinGW

69bedd1

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it. CC rust-lang#150725

make MarkdownItemInfo a field struct

64c78f6

render intra-doc links in the #[deprectated] note

3be74a7

Minor cleanups to fn_abi_new_uncached

aec8b69

Update libc to v0.2.180

47c5f58

Update literal-escaper version to 0.0.7

27b1083

store defids instead of symbol names in the aliases list

6b88c6b

MGCA: literals support

9f3956f

Rollup merge of rust-lang#150475 - uefi-fs-file, r=ChrisDenton

8cbea3c

std: sys: fs: uefi: Implement initial File - Implement basic opening and creating files. - Also implement debug. @rustbot label +O-UEFI

matthiaskrgr added 5 commits January 8, 2026 20:35

Rollup merge of rust-lang#150802 - fn_abi_cleanup, r=lqd

d51a6e9

Minor cleanups to fn_abi_new_uncached

Rollup merge of rust-lang#150803 - update-builtins, r=tgross35

0073a93

compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@65624df. Created using https://github.com/rust-lang/josh-sync. r? @ghost

Rollup merge of rust-lang#150809 - update-literal-escaper, r=Urgau

91ff785

Update `literal-escaper` version to `0.0.7` It removes the `std` dependency for this crate (which doesn't change anything for rustc 😄 ). cc @bjorn3 r? @Urgau

rust-bors bot added the rollup A PR which is a rollup label Jan 8, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2026

matthiaskrgr mentioned this pull request Jan 8, 2026

std: sys: fs: uefi: Implement initial File #150475

Merged

matthiaskrgr closed this Jan 8, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 12 pull requests #150830

Rollup of 12 pull requests #150830

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Rollup of 12 pull requests #150830

Rollup of 12 pull requests #150830

Uh oh!

Conversation

matthiaskrgr commented Jan 8, 2026

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants