Skip to content

fix missing_panics_doc in std::os::fd::owned #150549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 9, 2026
Merged

fix missing_panics_doc in std::os::fd::owned #150549

rust-bors merged 1 commit into from
Jan 9, 2026
+9 −1

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 31, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@xtqqczze xtqqczze mentioned this pull request Dec 31, 2025
Closed
hkBst
hkBst approved these changes Jan 3, 2026
View reviewed changes
Copy link
Member

@hkBst hkBst left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly documents current behavior (already panics via NotAllOnes::new().expect()) and makes it clear that this is not a Safety requirement.

View changes since this review

@ChrisDenton
Copy link
Member

ChrisDenton commented Jan 8, 2026

Thanks!

@bors r+ rollup

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 215768a has been approved by ChrisDenton

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
b25a0bb 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
@rust-bors
Auto merge of #150830 - matthiaskrgr:rollup-x97BiJe, r=matthiaskrgr
c6f0428 
Rollup of 12 pull requests

Successful merges:

 - #149961 (tidy: add if-installed prefix condition to extra checks system)
 - #150475 (std: sys: fs: uefi: Implement initial File)
 - #150533 (std: sys: fs: uefi: Implement remove_dir_all)
 - #150549 (fix missing_panics_doc in `std::os::fd::owned`)
 - #150699 (MGCA: Support literals as direct const arguments)
 - #150721 (Deprecated doc intra link)
 - #150752 (Update libc to v0.2.180)
 - #150802 (Minor cleanups to fn_abi_new_uncached)
 - #150803 (compiler-builtins subtree update)
 - #150809 (Update `literal-escaper` version to `0.0.7`)
 - #150811 (Store defids instead of symbol names in the aliases list)
 - #150825 (Query associated_item_def_ids when needed)

r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
ae4aeb6 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
158f1c6 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2026
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
b176ef4 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
0fcd2e9 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
069c8e6 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
@matthiaskrgr
Rollup merge of rust-lang#150549 - patch-1, r=ChrisDenton
2d7138c 
fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
This was referenced Jan 8, 2026
Closed
Merged
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
@rust-bors
Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr
3fda0e4 
Rollup of 11 pull requests

Successful merges:

 - #149961 (tidy: add if-installed prefix condition to extra checks system)
 - #150475 (std: sys: fs: uefi: Implement initial File)
 - #150533 (std: sys: fs: uefi: Implement remove_dir_all)
 - #150549 (fix missing_panics_doc in `std::os::fd::owned`)
 - #150699 (MGCA: Support literals as direct const arguments)
 - #150721 (Deprecated doc intra link)
 - #150802 (Minor cleanups to fn_abi_new_uncached)
 - #150803 (compiler-builtins subtree update)
 - #150809 (Update `literal-escaper` version to `0.0.7`)
 - #150811 (Store defids instead of symbol names in the aliases list)
 - #150825 (Query associated_item_def_ids when needed)

r? @ghost
@rust-bors rust-bors bot merged commit e7560df into rust-lang:main Jan 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 9, 2026
rust-timer added a commit that referenced this pull request Jan 9, 2026
@rust-timer
Unrolled build for #150549
ca47f13 
Rollup merge of #150549 - patch-1, r=ChrisDenton

fix missing_panics_doc in `std::os::fd::owned`

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hkBst hkBst hkBst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrisDenton ChrisDenton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @rustbot @ChrisDenton @hkBst