Fix trait method anchor disappearing before user can click on it #150816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
camelid
reviewed
Jan 8, 2026
tests/rustdoc-gui/anchors.goml
Outdated
Comment on lines
56
to
58
| // Now we move the cursor to the anchor to check there is no gap between the method and the | ||
| // anchor, making the anchor disappear and preventing users to click on it. | ||
| move-cursor-to: "#method\.vroum .anchor" |
Member
There was a problem hiding this comment.
Is this cursor move accomplished instantaneously, or does it move realistically in a gradual way? Ideally we'd make sure that even if it's done slowly, the anchor doesn't disappear.
Member
Author
There was a problem hiding this comment.
Instantly. But moving at a given speed could be interesting. Gonna need to add this option in browser-ui-test.
Member
There was a problem hiding this comment.
Maybe the instantaneous move is why we haven't been able to successfully test this before? Could you check if this new test fails without your CSS fix?
Member
Author
There was a problem hiding this comment.
Hum yeah it still passes. Not fun... :-/
camelid
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
method-anchor
branch
from
72cc903 to
a50ad76
Compare
GuillaumeGomez
force-pushed
the
method-anchor
branch
from
a50ad76 to
16fbf6a
Compare
Member
Author
|
Found a way! I instead move the cursor just a bit left to the method. Failed without the fix, works with it. So all good. =D I added a comment explaining that too. |
camelid
approved these changes
Jan 8, 2026
Member
|
@bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
Contributor
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Fix trait method anchor disappearing before user can click on it A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the `§` anchor of the `tcx` method. The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^'). First commit fixes the bug by expanding the anchor size. Second commit is a small clean-up of the GUI test. Third commit actually adds the GUI regression test. cc @BoxyUwU r? @camelid
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Fix trait method anchor disappearing before user can click on it A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the `§` anchor of the `tcx` method. The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^'). First commit fixes the bug by expanding the anchor size. Second commit is a small clean-up of the GUI test. Third commit actually adds the GUI regression test. cc @BoxyUwU r? @camelid
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
Fix trait method anchor disappearing before user can click on it A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the `§` anchor of the `tcx` method. The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^'). First commit fixes the bug by expanding the anchor size. Second commit is a small clean-up of the GUI test. Third commit actually adds the GUI regression test. cc @BoxyUwU r? @camelid
rust-bors bot
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup of 11 pull requests Successful merges: - #150272 (docs(core): update `find()` and `rfind()` examples) - #150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - #150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - #150574 (Clarify `MoveData::init_loc_map`.) - #150762 (Use functions more in rustdoc GUI tests) - #150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - #150816 (Fix trait method anchor disappearing before user can click on it) - #150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - #150829 (make attrs actually use `Target::GenericParam`) - #150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - #150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 9, 2026
Rollup merge of #150816 - method-anchor, r=camelid Fix trait method anchor disappearing before user can click on it A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the `§` anchor of the `tcx` method. The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^'). First commit fixes the bug by expanding the anchor size. Second commit is a small clean-up of the GUI test. Third commit actually adds the GUI regression test. cc @BoxyUwU r? @camelid
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 12, 2026
Rollup of 11 pull requests Successful merges: - rust-lang/rust#150272 (docs(core): update `find()` and `rfind()` examples) - rust-lang/rust#150385 (fix `Expr::can_have_side_effects` for `[x; N]` style array literal and binary expressions) - rust-lang/rust#150561 (Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency`) - rust-lang/rust#150574 (Clarify `MoveData::init_loc_map`.) - rust-lang/rust#150762 (Use functions more in rustdoc GUI tests) - rust-lang/rust#150808 (rename the `derive_{eq, clone_copy}` features to `*_internals`) - rust-lang/rust#150816 (Fix trait method anchor disappearing before user can click on it) - rust-lang/rust#150821 (tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed)) - rust-lang/rust#150829 (make attrs actually use `Target::GenericParam`) - rust-lang/rust#150834 (Add tracking issue for `feature(multiple_supertrait_upcastable)`) - rust-lang/rust#150864 (The aarch64-unknown-none target requires NEON, so the docs were wrong.) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the
§anchor of thetcxmethod.The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^').
First commit fixes the bug by expanding the anchor size.
Second commit is a small clean-up of the GUI test.
Third commit actually adds the GUI regression test.
cc @BoxyUwU
r? @camelid