Use functions more in rustdoc GUI tests #150762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
cleanup-gui
branch
from
82c3bf1 to
0433639
Compare
Member
Author
|
And fixed |
lolbinarycat
reviewed
Jan 8, 2026
Comment on lines
25
to
34
| call-function: ("check-colors", { | ||
| "theme": "dark", | ||
| "doc_code_color": "#ddd", | ||
| "doc_inline_code_color": "#ddd", | ||
| }) | ||
| call-function: ("check-colors", { | ||
| "theme": "light", | ||
| "doc_code_color": "black", | ||
| "doc_inline_code_color": "black", | ||
| }) |
Contributor
There was a problem hiding this comment.
Why was this removed??
Member
Author
There was a problem hiding this comment.
Woops. When I was debugging an issue in browser-ui-test I removed the extra lines to get less noise. Good catch!
GuillaumeGomez
force-pushed
the
cleanup-gui
branch
from
0433639 to
945e7c7
Compare
Member
Author
|
Put back wrongly removed code. |
Contributor
|
Thanks! @bors r+ |
rust-bors
bot
added
S-waiting-on-bors
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that conditions are supported in
browser-ui-test, we can start simplify some parts of the tests. This is a first cleanup, but I guess a lot more could be simplified. For follow-ups I guess. :)I made some improvements in backtrace display in
browser-ui-test, hence the version update once more.r? @lolbinarycat