Skip to content

std: sys: fs: uefi: Ignore "." and ".." when reading directory - #150516

Merged
bors merged 1 commit into
rust-lang:mainfrom
Ayush1325:uefi-fs-readdir-fix
Dec 31, 2025
Merged

std: sys: fs: uefi: Ignore "." and ".." when reading directory#150516
bors merged 1 commit into
rust-lang:mainfrom
Ayush1325:uefi-fs-readdir-fix

Conversation

@Ayush1325

Copy link
Copy Markdown
Contributor
  • At least in Unix, "." and ".." are not returned as a directory entry. So ignore these in UEFI as well.
  • Will also allow using the remove_dir_all implementation from sys/fs/common.

At least in Unix, "." and ".." are not returned as a directory entry. So
ignore these in UEFI as well.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 30, 2025
@rustbot

rustbot commented Dec 30, 2025

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Ayush1325

Copy link
Copy Markdown
Contributor Author

@rustbot label +O-UEFI

@jhpratt

jhpratt commented Dec 31, 2025

Copy link
Copy Markdown
Member

Given the obviousness of this and your history working on UEFI, I checked and as far as I can tell this does not need explicit approval from a target maintainer.

@bors r+ rollup

@bors

bors commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c2fc43c has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2025
@bors

bors commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c2fc43c with merge ab32c26...

@bors

bors commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing ab32c26 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2025
@bors
bors merged commit ab32c26 into rust-lang:main Dec 31, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 31, 2025
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 94f8f40 (parent) -> ab32c26 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ab32c26b49eacb1b694972bb29d20167bdbdfc51 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc: 3093.9s -> 3689.4s (+19.2%)
  2. pr-check-1: 1678.7s -> 1991.1s (+18.6%)
  3. dist-apple-various: 4081.2s -> 4662.7s (+14.2%)
  4. x86_64-gnu-debug: 6350.5s -> 7235.5s (+13.9%)
  5. x86_64-gnu-llvm-20-1: 3978.6s -> 4529.3s (+13.8%)
  6. x86_64-rust-for-linux: 2759.7s -> 3129.3s (+13.4%)
  7. i686-gnu-nopt-1: 7427.6s -> 8407.9s (+13.2%)
  8. i686-gnu-2: 5360.0s -> 6055.6s (+13.0%)
  9. x86_64-gnu-tools: 3281.4s -> 3691.0s (+12.5%)
  10. aarch64-apple: 11074.3s -> 12398.9s (+12.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Ayush1325
Ayush1325 deleted the uefi-fs-readdir-fix branch December 31, 2025 06:51
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ab32c26): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.208s -> 481.911s (-0.06%)
Artifact size: 390.84 MiB -> 390.84 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants