Skip to content

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Jul 13, 2025

I made a new branch with patches that aren't yet in LLVM 20.1.8.

@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@Patryk27
Copy link
Contributor

After this is merged, we'll be able to merge #142454 as well (thanks to rust-lang/llvm-project#185).

@dianqk
Copy link
Member Author

dianqk commented Jul 13, 2025

After this is merged, we'll be able to merge #142454 as well (thanks to rust-lang/llvm-project#185).

My concern is that this introduces new features. But, for this specific scenario, it appears to be acceptable.

@nikic
Copy link
Contributor

nikic commented Jul 13, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

📌 Commit 0ba392c has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025
@bors
Copy link
Collaborator

bors commented Jul 14, 2025

⌛ Testing commit 0ba392c with merge 64b185e...

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 64b185e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2025
@bors bors merged commit 64b185e into rust-lang:master Jul 14, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 14, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ad635e5 (parent) -> 64b185e (this PR)

Test differences

Show 12 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J0)
  • [assembly] tests/assembly/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.8) is newer than majorversion 19) (J1)
  • [assembly] tests/assembly/sanitizer/kcfi/emit-arity-indicator.rs#x86_64: ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.8 is older than 21.0.0) (J1)
  • [assembly] tests/assembly/x86_64-bigint-helpers.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.8) is newer than majorversion 19) (J1)
  • [codegen] tests/codegen/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.8) is newer than majorversion 19) (J1)
  • [codegen] tests/codegen/issues/issue-101082.rs#x86-64-v3: ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.8 is older than 21.0.0) (J1)
  • [codegen] tests/codegen/option-niche-eq.rs#LLVM21: ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.8 is older than 21.0.0) (J1)
  • [codegen] tests/codegen/sanitizer/kcfi/add-kcfi-arity-flag.rs#x86_64: ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.8 is older than 21.0.0) (J1)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.8) is newer than majorversion 19) (J2)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.8) is newer than majorversion 19) (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 64b185eddaa1d7ddf5e0c024be23b9cbba6c1722 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3854.9s -> 6104.3s (58.4%)
  2. pr-check-1: 1583.0s -> 2191.6s (38.4%)
  3. dist-x86_64-apple: 8381.1s -> 11081.5s (32.2%)
  4. x86_64-rust-for-linux: 2889.5s -> 3588.2s (24.2%)
  5. aarch64-apple: 5827.1s -> 7150.4s (22.7%)
  6. tidy: 70.5s -> 55.2s (-21.7%)
  7. test-various: 4810.7s -> 5675.2s (18.0%)
  8. x86_64-gnu-nopt: 7373.2s -> 8605.1s (16.7%)
  9. x86_64-gnu-tools: 3733.3s -> 4337.7s (16.2%)
  10. x86_64-gnu-miri: 5023.0s -> 5822.4s (15.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@dianqk dianqk deleted the update-llvm branch July 14, 2025 13:02
@bors bors mentioned this pull request Jul 14, 2025
8 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (64b185e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
8.7% [8.7%, 8.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-6.4% [-6.4%, -6.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [-6.4%, 8.7%] 2

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.735s -> 463.69s (-0.44%)
Artifact size: 374.64 MiB -> 374.63 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants