Backport #144229 #185
Merged
Backport #144229 #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added the missing XMEGA2 definition. The avr64 devices use xmega2 which has SPM(X) defined. 2. The avr16/avr32 devices do have SPM and SPMX features, but the current xmega3 definition has not. Xmega3 is also used for modern attiny series which do not have SPM(X), so that is correct. Leave the avr16/avr32 devices unchanged (using xmega3 to be in sync with gcc definitions). Fixes llvm#116116
dianqk
approved these changes
Jul 13, 2025
|
Updated to Rust: rust-lang/rust#143873. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #184 - didn't realize that a newly-introduced test there uses an AVR MCU that's been introduced in yet another commit. I've also considered backporting the test to use another MCU, one that's already available, but that would require adjusting the test's assembly output, leaving cherry-picking the MCUs as the easier way out.
Thanks to @dianqk.