-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Add a regression test for ld64 #143126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dianqk
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
dianqk:update-llvm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−0
Draft
Add a regression test for ld64 #143126
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
//@ compile-flags: -Copt-level=3 -Ccodegen-units=256 -Clink-arg=-ld_classic --target x86_64-apple-darwin | ||
//@ run-pass | ||
//@ only-macos | ||
//@ needs-llvm-components: x86 | ||
|
||
// This is a regression test for https://github.com/rust-lang/rust/issues/140686. | ||
// Although this is a ld64(ld-classic) bug, we still need to support it | ||
// due to cross-compilation and support for older Xcode. | ||
|
||
fn main() { | ||
let dst: Vec<u8> = Vec::new(); | ||
let len = broken_func(2, dst); | ||
assert_eq!(len, 8); | ||
} | ||
|
||
#[inline(never)] | ||
pub fn broken_func(version: usize, mut dst: Vec<u8>) -> usize { | ||
match version { | ||
1 => dst.extend_from_slice(b"aaaaaaaa"), | ||
2 => dst.extend_from_slice(b"bbbbbbbb"), | ||
3 => dst.extend_from_slice(b"bbbbbbbb"), | ||
_ => panic!(), | ||
} | ||
dst.len() | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we know if
ld-classic
will ever be removed in newer Xcode versions?(EDIT: actually probably nevermind, we'll then either drop this test and/or need to bump our min baseline versions anyway.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody knows. Even after removing it, we might still need a long time to get rid of the test. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could wait for new updates from Apple first, such as a fix for the ld64 bug, or the release of new linker source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh for the test I'm not too worried even if somehow say a macos image bumps the xcode version and then this test blocks full CI, in that situation this test can be disabled or removed easily.
I was just musing if ld-classic might be gone.