Add a regression test for ld64 #143126
Add a regression test for ld64 #143126
Conversation
rustbot
added
the
T-compiler
|
I'm currently unable to access my Mac. @bors2 try jobs=x86_apple*,aarch64-apple |
Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_apple* try-job: aarch64-apple
| // This is a regression test for https://github.com/rust-lang/rust/issues/140686. | ||
| // Although this is a ld64(ld-classic) bug, we still need to support it | ||
| // due to cross-compilation and support for older Xcode. |
There was a problem hiding this comment.
Question: do we know if ld-classic will ever be removed in newer Xcode versions?
(EDIT: actually probably nevermind, we'll then either drop this test and/or need to bump our min baseline versions anyway.)
There was a problem hiding this comment.
Nobody knows. Even after removing it, we might still need a long time to get rid of the test. :(
There was a problem hiding this comment.
Perhaps we could wait for new updates from Apple first, such as a fix for the ld64 bug, or the release of new linker source code.
There was a problem hiding this comment.
Oh for the test I'm not too worried even if somehow say a macos image bumps the xcode version and then this test blocks full CI, in that situation this test can be disabled or removed easily.
I was just musing if ld-classic might be gone.
|
💔 Test failed
|
|
@bors2 try jobs=x86_64-apple*,aarch64-apple |
Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_64-apple* try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
|
@bors2 try jobs=x86_64-apple*,aarch64-apple |
Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_64-apple* try-job: aarch64-apple
|
💔 Test failed
|
We might want a test case.
r? ghost