Rollup of 7 pull requests #142242
Merged
Rollup of 7 pull requests #142242
+540
−494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.
…-recommend-over-recommended
rustdoc: Further improve chapters and sections on testing
…est-suite Follow up: Fix typo
I couldn't find existing tests that for this behavior, so this should make sure it doesn't accidentally change.
remove the archived ICE ping groups
Rustc pull update
So that we can make sure that they are reproducible locally.
This allows us to reuse its cache on PR CI jobs.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
…ayer, r=tgross35
Stabilize `tcp_quickack`
to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.
The related API calls are the following
```rust
// std::os::linux::net
// sealed trait, implemented for std::net::TcpStream
pub trait TcpStreamExt: Sealed{
fn quickack(&self) -> io::Result<bool>;
fn set_quickack(&self, quickack: bool) -> io::Result<()>;
}
```
Closes: rust-lang#96256
…=tgross35 De-duplicate f16 & f128 doctest attributes Now that rustdoc supports `#[doc(test(attr(...)))]` at every level, thanks to rust-lang#140560, we can de-duplicate the f16 & f128 doctest attributes. Unfortunately we can de-duplicate the `cfg`s attribute as rustdoc would complain about missing `main`, but it's already much better than before. Addresses https://github.com/rust-lang/rust/pull/140323/files#r2062702761 r? `@tgross35`
…e-tests, r=Nadrieril add tests for pattern binding drop order edge cases This adds tests for rust-lang#142163, rust-lang#142057, and rust-lang#142056. I'm using these tests to help make sure I don't commit breaking changes when implementing match lowering for guard patterns, but I think it makes sense to add them separately. They don't directly have anything to do with guard patterns. r? `@Nadrieril` or reassign
Dont make `ObligationCtxt`s with diagnostics unnecessarily just a nit, shouldn't affect perf b/c `ObligationCtxt::new_with_diagnostics` should only be more expensive in the new trait solver, and I don't expect either of these to encounter errors today anyways. r? oli-obk
rustc-dev-guide subtree update r? `@ghost`
Run `calculate_matrix` job on `master` to cache citool builds As discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/PR.20ci.20seems.20much.20to.20slow/with/523028903, the current `rust-cache` solution for `citool` doesn't work, because we don't ever write to the cache from `master`, so the cache is empty on PR CI jobs. This PR runs the `calculate_matrix` job on `master`, with the only motivation to actually prime the cache. r? `@marcoieni`
add `Cargo.lock` to CI-rustc allowed list for non-CI env Changes to dependencies usually require modifying `Cargo.toml`, which would already invalidate the CI-rustc cache if done in non-allowed paths. On non-CI environment, it should be safe to add `Cargo.lock` to the list of allowed paths as there is no real risk aside from a very rare false positive in cases like minor bumps to non-allowed path dependencies without modifying the `Cargo.toml` files. Fixes rust-lang#141986
rustbot
added
A-rustc-dev-guide
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 7c10378e1f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7c10378 (parent) -> 14863ea (this PR) Test differencesShow 190 test diffsStage 1
Stage 2
Additionally, 184 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 14863ea0777c68348b3e6e7a8472423d273a52af --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tcp_quickack#129121 (Stabilizetcp_quickack)ObligationCtxts with diagnostics unnecessarily #142222 (Dont makeObligationCtxts with diagnostics unnecessarily)calculate_matrixjob onmasterto cache citool builds #142231 (Runcalculate_matrixjob onmasterto cache citool builds)Cargo.lockto CI-rustc allowed list for non-CI env #142232 (addCargo.lockto CI-rustc allowed list for non-CI env)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup