Run calculate_matrix job on master to cache citool builds
#142231
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can make sure that they are reproducible locally.
This allows us to reuse its cache on PR CI jobs.
rustbot
added
A-testsuite
|
wouldn't using s3 with sccache instead of doing this improve performance even more? |
|
Using S3 would probably have similar performance, but it would be more complicated. For starters, we would need to install |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 9, 2025
Run `calculate_matrix` job on `master` to cache citool builds As discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/PR.20ci.20seems.20much.20to.20slow/with/523028903, the current `rust-cache` solution for `citool` doesn't work, because we don't ever write to the cache from `master`, so the cache is empty on PR CI jobs. This PR runs the `calculate_matrix` job on `master`, with the only motivation to actually prime the cache. r? `@marcoieni`
bors
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup of 7 pull requests Successful merges: - #129121 (Stabilize `tcp_quickack`) - #142192 (De-duplicate f16 & f128 doctest attributes) - #142193 (add tests for pattern binding drop order edge cases) - #142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - #142228 (rustc-dev-guide subtree update) - #142231 (Run `calculate_matrix` job on `master` to cache citool builds) - #142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/PR.20ci.20seems.20much.20to.20slow/with/523028903, the current
rust-cachesolution forcitooldoesn't work, because we don't ever write to the cache frommaster, so the cache is empty on PR CI jobs.This PR runs the
calculate_matrixjob onmaster, with the only motivation to actually prime the cache.r? @marcoieni