-
Notifications
You must be signed in to change notification settings - Fork 13.4k
move test-float-parse
tool into src/tools
dir
#141949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
This makes sense to me, but I wonder if there was some reason to actually put this under |
This comment has been minimized.
This comment has been minimized.
That's just where the python version was, I have no preference :) |
Obviously `test-float-parse` is a tool like any other in `src/tools`. Signed-off-by: onur-ozkan <work@onurozkan.dev>
769657e
to
59fbe04
Compare
Ok :) Feel free to r=me after CI is green. |
It's confusing not to have a clear distinction between these two ( |
@bors r+ r=Kobzol |
Rollup of 9 pull requests Successful merges: - #141554 (Improve documentation for codegen options) - #141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…) - #141843 (Add `visit_id` to ast `Visitor`) - #141881 (Subtree update of `rust-analyzer`) - #141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id) - #141921 (Disable f64 minimum/maximum tests for arm 32) - #141930 (Enable triagebot `[concern]` functionality) - #141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`) - #141949 (move `test-float-parse` tool into `src/tools` dir) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #141949 - onur-ozkan:move-test-float-parse, r=Kobzol move `test-float-parse` tool into `src/tools` dir Obviously `test-float-parse` is a tool like any other in `src/tools`. cc `@tgross35`
Obviously
test-float-parse
is a tool like any other insrc/tools
.cc @tgross35