Skip to content

rustc_llvm: add Windows system libs only when cross-compiling from Wi… #141817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mati865
Copy link
Member

@mati865 mati865 commented May 31, 2025

…ndows

This obviously doesn't work when cross-compiling from Linux.

Split out from: #140772

Fixes the issue described at #general > Problems while trying to cross compile rustc for windows

…ndows

This obviously doesn't work when cross-compiling from Linux.

Split out from: rust-lang#140772
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 31, 2025
@cuviper
Copy link
Member

cuviper commented Jun 2, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 81f61ac has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…-compiling, r=cuviper

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

…ndows

This obviously doesn't work when cross-compiling from Linux.

Split out from: rust-lang#140772

Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…-compiling, r=cuviper

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

…ndows

This obviously doesn't work when cross-compiling from Linux.

Split out from: rust-lang#140772

Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)
bors added a commit that referenced this pull request Jun 3, 2025
Rollup of 9 pull requests

Successful merges:

 - #141554 (Improve documentation for codegen options)
 - #141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…)
 - #141843 (Add `visit_id` to ast `Visitor`)
 - #141881 (Subtree update of `rust-analyzer`)
 - #141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id)
 - #141921 (Disable f64 minimum/maximum tests for arm 32)
 - #141930 (Enable triagebot `[concern]` functionality)
 - #141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`)
 - #141949 (move `test-float-parse` tool into `src/tools` dir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2da4bae into rust-lang:master Jun 3, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
rust-timer added a commit that referenced this pull request Jun 3, 2025
Rollup merge of #141817 - mati865:fix-system-libs-when-cross-compiling, r=cuviper

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

…ndows

This obviously doesn't work when cross-compiling from Linux.

Split out from: #140772

Fixes the issue described at [#general > Problems while trying to cross compile rustc for windows](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Problems.20while.20trying.20to.20cross.20compile.20rustc.20for.20windows/with/520508561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants