Skip to content

Subtree update of rust-analyzer #141278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
May 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
f6f92a2
feat: highlight unsafe operations
gohome001 Apr 25, 2025
9031c86
test: add test case for highlight unsafe operations
gohome001 Apr 25, 2025
2ec0650
minor: format
gohome001 Apr 25, 2025
bad7d12
Fix incorrect handling of unresolved non-module imports in name resol…
Veykril May 5, 2025
5ba589b
Merge pull request #19742 from Veykril/push-ykmuwtkzruqm
Veykril May 5, 2025
79f0e29
refactor: De-arc defmap queries
Veykril Apr 28, 2025
d24c37e
Merge pull request #19707 from Veykril/push-kqkpzkymkyyl
Veykril May 5, 2025
77f7a9a
feat: add an assist to unwrap a type with a generic arg
vishruth-thimmaiah May 4, 2025
a6e71ba
Merge pull request #19740 from vishruth-thimmaiah/unwrap_path_type
Veykril May 5, 2025
c1b7b96
minor: Add a mbe test for parsing negative literals
Veykril May 5, 2025
ad6f9f7
Merge pull request #19745 from Veykril/push-rnqulnqvltro
Veykril May 5, 2025
53881ef
minor: Add more proc-macro tests for parsing negative literals
Veykril May 5, 2025
4f0c28e
fix: Fix proc-macro API creating malformed negative literals
Veykril May 5, 2025
d5c97d3
Merge pull request #19746 from Veykril/push-swvuyqwwplrt
Veykril May 5, 2025
845106e
fix: Fix `move_bounds` assists not working for lifetimes
Veykril May 5, 2025
b858b97
Merge pull request #19747 from Veykril/push-kqxvxrxozswr
Veykril May 5, 2025
63e7c7e
fix: negative nums in `concat!` expansion
vishruth-thimmaiah Mar 23, 2025
37cbd83
Merge pull request #19434 from vishruth-thimmaiah/negatives_in_concat
Veykril May 5, 2025
5620b39
github: Direct users to discussions instead of issues for questions
Veykril May 5, 2025
941e8f1
refactor: Remove unnecessary `AsAny` trait
Veykril May 5, 2025
227dd28
Merge pull request #19748 from Veykril/push-qvmtutwtonou
Veykril May 5, 2025
b41d379
Merge pull request #19749 from Veykril/push-tsxvxzzmlxpq
Veykril May 5, 2025
c3bdb24
fix: Remove unnecessary token length check for macros in renaming
Veykril May 5, 2025
2e7b86d
Merge pull request #19750 from Veykril/push-zvvsopwxovrn
Veykril May 5, 2025
d246efe
Support environment variable CARGO_MANIFEST_PATH.
VictorArcium May 5, 2025
2636676
Better manage parallel prime caches
ChayimFriedman2 Apr 30, 2025
6fa168a
Add a `--num-threads` to the `prime-caches` CLI command
ChayimFriedman2 Apr 30, 2025
bb584e8
Merge pull request #19751 from VictorArcium/env-var-cargo-manifest-path
ChayimFriedman2 May 5, 2025
bce6763
Notify the user that we're collecting symbols
ChayimFriedman2 May 6, 2025
0b75b2d
Merge pull request #19721 from ChayimFriedman2/more-parallel
Veykril May 6, 2025
1ed416d
Don't panic on some weird code
ChayimFriedman2 May 6, 2025
546065a
fix: resolve doc path if outer comments exist on module and replace f…
Hmikihiro Mar 28, 2025
b9a3e70
Update crates/hir-expand/src/attrs.rs
Hmikihiro May 6, 2025
674e10e
Update crates/hir-expand/src/attrs.rs
Hmikihiro May 6, 2025
a8b8b2b
import std::iter::repeat
Hmikihiro May 6, 2025
7bf0c00
Remove ast index mask
Hmikihiro May 6, 2025
45f2d3c
Merge pull request #19738 from ChayimFriedman2/weird-gats
Veykril May 6, 2025
8935d0b
check module path inner or outer
Hmikihiro May 6, 2025
ecb59e1
add doc link test for goto def
Hmikihiro May 6, 2025
449d720
add doc link test for hover
Hmikihiro May 6, 2025
627fedb
extract function: `doc_attributes` to find def from inner doc
Hmikihiro May 6, 2025
db9c18e
Still complete parentheses & method call arguments if there are exist…
ChayimFriedman2 May 8, 2025
99be5d4
perf: Request cancellation while processing changed files
Veykril May 7, 2025
4c69f8d
Merge pull request #19763 from ChayimFriedman2/ws-completions
Veykril May 8, 2025
322451c
Fix postfix snippets duplicating derefs
ChayimFriedman2 May 8, 2025
321a6d6
Merge pull request #19764 from ChayimFriedman2/too-many-asterisks-dbg
ChayimFriedman2 May 8, 2025
656a59e
add assert to check ast_index smaller than INNER_ATTR_SET_BIT
Hmikihiro May 8, 2025
85ab1c4
Merge pull request #19507 from Hmikihiro/fix_module_doc_links
Veykril May 8, 2025
1c53e27
Make diagnostics experimental by default
flodiebold May 9, 2025
0092abd
minor: code review tweak
gohome001 May 10, 2025
6a44ce5
Merge pull request #19772 from rust-lang/push-nxzlokoozypo
Veykril May 10, 2025
6274d46
fix: Removing all unused imports removes used imports for imports use…
Hmikihiro May 14, 2025
de51196
Don't allow duplicate crates in the all_crates list
ChayimFriedman2 May 14, 2025
5adbda4
rename fn name take_path to any
Hmikihiro May 15, 2025
2c55a78
check glob
Hmikihiro May 15, 2025
034d2a2
handle trait in function
Hmikihiro May 15, 2025
66fef16
Update Cargo.lock
Berrysoft May 15, 2025
7a84531
Merge pull request #19796 from Berrysoft/update-cargo-lock
lnicola May 15, 2025
2e718f8
Merge pull request #19793 from Hmikihiro/unused_import_conlict_derive
ChayimFriedman2 May 15, 2025
bcb7a1a
Merge pull request #19794 from ChayimFriedman2/dup-crates
Veykril May 15, 2025
6c21c9f
Bump undici from 6.21.1 to 6.21.3 in /editors/code
dependabot[bot] May 15, 2025
98b6ecd
Merge pull request #19798 from rust-lang/dependabot/npm_and_yarn/edit…
ChayimFriedman2 May 15, 2025
ae304db
Improve asm support
ChayimFriedman2 May 15, 2025
8de8ca3
Merge pull request #19801 from ChayimFriedman2/asm-label
Veykril May 16, 2025
428279e
Bump zip to 3.0
lnicola May 16, 2025
13c5e0e
Merge pull request #19804 from lnicola/bump-zip
lnicola May 16, 2025
4860712
Inline some format args
lnicola May 16, 2025
cea2aeb
Merge pull request #19805 from lnicola/inline-format-args
lnicola May 16, 2025
10f4f6a
fix: Don't overwrite `RUSTUP_TOOLCHAIN` if it is already set
Veykril May 16, 2025
4d5c638
Merge pull request #19807 from Veykril/lw-qyynkqysuyuy
Veykril May 16, 2025
45865f2
ci: Run metrics on the beta channel
Veykril May 16, 2025
1d073db
Merge pull request #19808 from Veykril/lw-ollszwnlmquw
Veykril May 16, 2025
c04873b
Catch panics in inference in analysis-stats
flodiebold May 16, 2025
7e4bbe1
Merge pull request #19687 from gohome001/highlight_unsafe
Veykril May 18, 2025
0e63f08
Merge pull request #19757 from Veykril/push-zzxwtzuzqvzx
Veykril May 19, 2025
e493cb1
Debounce workspace fetching for workspace structure changes
Veykril May 17, 2025
d6859ad
Merge pull request #19814 from Veykril/lw-sxquntxksovs
Veykril May 19, 2025
84ed11b
Merge pull request #19809 from flodiebold/push-txyotwlvvkln
Veykril May 19, 2025
9f82458
Remote dangling file
Veykril May 19, 2025
a1d75fb
Merge pull request #19822 from Veykril/push-mzzluystvwls
Veykril May 19, 2025
1dafeea
Preparing for merge from rust-lang/rust
lnicola May 20, 2025
50a6c5b
Merge from rust-lang/rust
lnicola May 20, 2025
a667495
Bump rustc crates
lnicola May 20, 2025
2147783
Merge pull request #19826 from lnicola/sync-from-rust
lnicola May 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/tools/rust-analyzer/.github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contact_links:
- name: Questions regarding rust-analyzer
url: https://github.com/rust-lang/rust-analyzer/discussions
about: Please ask and answer questions here instead of opening an issue
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,3 @@ Troubleshooting guide: https://rust-analyzer.github.io/book/troubleshooting.html

Please try to provide information which will help us to fix the issue faster. Minimal reproducible examples with few dependencies are especially lovely <3.
-->

This is a serious regression in nightly and it's important to fix it before the next release.
8 changes: 0 additions & 8 deletions src/tools/rust-analyzer/.github/ISSUE_TEMPLATE/question.md

This file was deleted.

12 changes: 6 additions & 6 deletions src/tools/rust-analyzer/.github/workflows/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
steps:
- name: Install Rust toolchain
run: |
rustup update --no-self-update stable
rustup default stable
rustup component add --toolchain stable rust-src
rustup update --no-self-update beta
rustup default beta
rustup component add --toolchain beta rust-src

- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -61,9 +61,9 @@ jobs:
steps:
- name: Install Rust toolchain
run: |
rustup update --no-self-update stable
rustup default stable
rustup component add --toolchain stable rust-src
rustup update --no-self-update beta
rustup default beta
rustup component add --toolchain beta rust-src

- name: Checkout repository
uses: actions/checkout@v4
Expand Down
143 changes: 87 additions & 56 deletions src/tools/rust-analyzer/Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ checksum = "ace50bade8e6234aa140d9a2f552bbee1db4d353f69b8217bc503490fc1a9f26"

[[package]]
name = "backtrace"
version = "0.3.74"
version = "0.3.75"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8d82cb332cdfaed17ae235a638438ac4d4839913cc2af585c3c6746e8f8bee1a"
checksum = "6806a6321ec58106fea15becdad98371e28d92ccbc7c8f1b3b6dd724fe8f1002"
dependencies = [
"addr2line",
"cfg-if",
Expand All @@ -80,6 +80,7 @@ version = "0.0.0"
dependencies = [
"cfg",
"dashmap",
"indexmap",
"intern",
"la-arena 0.3.1 (registry+https://github.com/rust-lang/crates.io-index)",
"query-group-macro",
Expand Down Expand Up @@ -316,9 +317,9 @@ checksum = "d0a5c400df2834b80a4c3327b3aad3a4c4cd4de0629063962b03235697506a28"

[[package]]
name = "ctrlc"
version = "3.4.5"
version = "3.4.7"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "90eeab0aa92f3f9b4e87f258c72b139c207d251f9cbc1080a0086b86a8870dd3"
checksum = "46f93780a459b7d656ef7f071fe699c4d3d2cb201c4b24d085b6ddc505276e73"
dependencies = [
"nix",
"windows-sys 0.59.0",
Expand Down Expand Up @@ -472,9 +473,9 @@ checksum = "0ce7134b9999ecaf8bcd65542e436736ef32ddca1b3e06094cb6ec5755203b80"

[[package]]
name = "flate2"
version = "1.1.0"
version = "1.1.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "11faaf5a5236997af9848be0bef4db95824b1d534ebc64d0f0c6cf3e67bd38dc"
checksum = "7ced92e76e966ca2fd84c8f7aa01a4aea65b0eb6648d72f7c8f3e2764a67fece"
dependencies = [
"crc32fast",
"miniz_oxide",
Expand Down Expand Up @@ -1010,9 +1011,9 @@ dependencies = [

[[package]]
name = "indexmap"
version = "2.8.0"
version = "2.9.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3954d50fe15b02142bf25d3b8bdadb634ec3948f103d04ffe3031bc8fe9d7058"
checksum = "cea70ddb795996207ad57735b50c5982d8844f38ba9ee5f1aedcfb708a2aa11e"
dependencies = [
"equivalent",
"hashbrown 0.15.2",
Expand Down Expand Up @@ -1123,12 +1124,12 @@ checksum = "d750af042f7ef4f724306de029d18836c26c1765a54a6a3f094cbd23a7267ffa"

[[package]]
name = "libloading"
version = "0.8.6"
version = "0.8.7"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "fc2f4eb4bc735547cfed7c0a4922cbd04a4655978c09b54f1f7b228750664c34"
checksum = "6a793df0d7afeac54f95b471d3af7f0d4fb975699f972341a4b76988d49cdf0c"
dependencies = [
"cfg-if",
"windows-targets 0.52.6",
"windows-targets 0.53.0",
]

[[package]]
Expand Down Expand Up @@ -1358,9 +1359,9 @@ dependencies = [

[[package]]
name = "nix"
version = "0.29.0"
version = "0.30.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "71e2746dc3a24dd78b3cfcb7be93368c6de9963d30f43a6a73998a9cf4b17b46"
checksum = "74523f3a35e05aba87a1d978330aef40f67b0304ac79c1c00b294c9830543db6"
dependencies = [
"bitflags 2.9.0",
"cfg-if",
Expand Down Expand Up @@ -1640,14 +1641,14 @@ dependencies = [

[[package]]
name = "process-wrap"
version = "8.2.0"
version = "8.2.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d35f4dc9988d1326b065b4def5e950c3ed727aa03e3151b86cc9e2aec6b03f54"
checksum = "a3ef4f2f0422f23a82ec9f628ea2acd12871c81a9362b02c43c1aa86acfc3ba1"
dependencies = [
"indexmap",
"nix",
"tracing",
"windows 0.59.0",
"windows 0.61.1",
]

[[package]]
Expand Down Expand Up @@ -1749,9 +1750,9 @@ dependencies = [

[[package]]
name = "ra-ap-rustc_abi"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "912228bd8ed3beff1f6f9e5e2d4b37c0827ba3e2070060bf3858a311d0e29e30"
checksum = "c33b8fa229789975647ca5426be432c7c327ebde89ab15889928185dbcee3230"
dependencies = [
"bitflags 2.9.0",
"ra-ap-rustc_hashes",
Expand All @@ -1761,28 +1762,28 @@ dependencies = [

[[package]]
name = "ra-ap-rustc_hashes"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ba520764daf057a9d963fa769f4762eaf87ac5d4900ae76195eeead64cd35afd"
checksum = "0d68a3e389927002f552938a90b04787f6435f55b46fc5691360470d1cb2e99d"
dependencies = [
"rustc-stable-hash",
]

[[package]]
name = "ra-ap-rustc_index"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b76b5f9ee55f2d0e5a65bea23f6d738893349ce8d3d17a6720933e647ab04978"
checksum = "32502273df2838d0ca13f1c67e2a48feef940e591f9771869f07e2db2acede53"
dependencies = [
"ra-ap-rustc_index_macros",
"smallvec",
]

[[package]]
name = "ra-ap-rustc_index_macros"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ddd972eb1face2fcaa0d94c01d97862fb955b5561d4f5932003bce8a6cadd8c6"
checksum = "8a32f081864ae34c7ae6634edfa7a95ab9260ba85015e8b1d347580eda79d14f"
dependencies = [
"proc-macro2",
"quote",
Expand All @@ -1791,9 +1792,9 @@ dependencies = [

[[package]]
name = "ra-ap-rustc_lexer"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ba3a9876456fb2521097deef33ddeac1c18260c8eafb68054d986f8b9d6ce9fa"
checksum = "ed34c51974718c5bd90d876d1364d9725159fc8030c2382b9cb837034152ed68"
dependencies = [
"memchr",
"unicode-properties",
Expand All @@ -1802,19 +1803,19 @@ dependencies = [

[[package]]
name = "ra-ap-rustc_parse_format"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8e85de58dfcc60a5f9d5ec0157a657e3f84abd8f22c8a0c4d707cfb42c9011f4"
checksum = "ff0440e5d27facbf4ff13ea651e48c2f6e360b3dbfc56251b41d60719b965fb8"
dependencies = [
"ra-ap-rustc_lexer",
"rustc-literal-escaper",
]

[[package]]
name = "ra-ap-rustc_pattern_analysis"
version = "0.110.0"
version = "0.113.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ceadf9db550db67deff7eff2e2765109b860c9d7e5bdfca144863020289c823d"
checksum = "a6056efa57aba3aa0cc69a0bf1a8281624c23ad25b05748d11ebcd4668037bfc"
dependencies = [
"ra-ap-rustc_index",
"rustc-hash 2.1.1",
Expand Down Expand Up @@ -2228,6 +2229,7 @@ version = "0.0.0"
dependencies = [
"backtrace",
"crossbeam-channel",
"crossbeam-utils",
"itertools 0.14.0",
"jod-thread",
"libc",
Expand Down Expand Up @@ -2750,12 +2752,24 @@ dependencies = [

[[package]]
name = "windows"
version = "0.59.0"
version = "0.61.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7f919aee0a93304be7f62e8e5027811bbba96bcb1de84d6618be56e43f8a32a1"
checksum = "c5ee8f3d025738cb02bad7868bbb5f8a6327501e870bf51f1b455b0a2454a419"
dependencies = [
"windows-core 0.59.0",
"windows-targets 0.53.0",
"windows-collections",
"windows-core 0.61.0",
"windows-future",
"windows-link",
"windows-numerics",
]

[[package]]
name = "windows-collections"
version = "0.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "3beeceb5e5cfd9eb1d76b381630e82c4241ccd0d27f1a39ed41b2760b255c5e8"
dependencies = [
"windows-core 0.61.0",
]

[[package]]
Expand All @@ -2773,15 +2787,25 @@ dependencies = [

[[package]]
name = "windows-core"
version = "0.59.0"
version = "0.61.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "810ce18ed2112484b0d4e15d022e5f598113e220c53e373fb31e67e21670c1ce"
checksum = "4763c1de310c86d75a878046489e2e5ba02c649d185f21c67d4cf8a56d098980"
dependencies = [
"windows-implement 0.59.0",
"windows-interface 0.59.0",
"windows-result 0.3.1",
"windows-strings 0.3.1",
"windows-targets 0.53.0",
"windows-implement 0.60.0",
"windows-interface 0.59.1",
"windows-link",
"windows-result 0.3.2",
"windows-strings 0.4.0",
]

[[package]]
name = "windows-future"
version = "0.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7a1d6bbefcb7b60acd19828e1bc965da6fcf18a7e39490c5f8be71e54a19ba32"
dependencies = [
"windows-core 0.61.0",
"windows-link",
]

[[package]]
Expand All @@ -2797,9 +2821,9 @@ dependencies = [

[[package]]
name = "windows-implement"
version = "0.59.0"
version = "0.60.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "83577b051e2f49a058c308f17f273b570a6a758386fc291b5f6a934dd84e48c1"
checksum = "a47fddd13af08290e67f4acabf4b459f647552718f683a7b415d290ac744a836"
dependencies = [
"proc-macro2",
"quote",
Expand All @@ -2819,9 +2843,9 @@ dependencies = [

[[package]]
name = "windows-interface"
version = "0.59.0"
version = "0.59.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "cb26fd936d991781ea39e87c3a27285081e3c0da5ca0fcbc02d368cc6f52ff01"
checksum = "bd9211b69f8dcdfa817bfd14bf1c97c9188afa36f4750130fcdf3f400eca9fa8"
dependencies = [
"proc-macro2",
"quote",
Expand All @@ -2830,9 +2854,19 @@ dependencies = [

[[package]]
name = "windows-link"
version = "0.1.0"
version = "0.1.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "76840935b766e1b0a05c0066835fb9ec80071d4c09a16f6bd5f7e655e3c14c38"

[[package]]
name = "windows-numerics"
version = "0.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "6dccfd733ce2b1753b03b6d3c65edf020262ea35e20ccdf3e288043e6dd620e3"
checksum = "9150af68066c4c5c07ddc0ce30421554771e528bde427614c61038bc2c92c2b1"
dependencies = [
"windows-core 0.61.0",
"windows-link",
]

[[package]]
name = "windows-result"
Expand All @@ -2845,9 +2879,9 @@ dependencies = [

[[package]]
name = "windows-result"
version = "0.3.1"
version = "0.3.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "06374efe858fab7e4f881500e6e86ec8bc28f9462c47e5a9941a0142ad86b189"
checksum = "c64fd11a4fd95df68efcfee5f44a294fe71b8bc6a91993e2791938abcc712252"
dependencies = [
"windows-link",
]
Expand All @@ -2864,9 +2898,9 @@ dependencies = [

[[package]]
name = "windows-strings"
version = "0.3.1"
version = "0.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "87fa48cc5d406560701792be122a10132491cff9d0aeb23583cc2dcafc847319"
checksum = "7a2ba9642430ee452d5a7aa78d72907ebe8cfda358e8cb7918a2050581322f97"
dependencies = [
"windows-link",
]
Expand Down Expand Up @@ -3230,17 +3264,14 @@ dependencies = [

[[package]]
name = "zip"
version = "2.4.2"
version = "3.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "fabe6324e908f85a1c52063ce7aa26b68dcb7eb6dbc83a2d148403c9bc3eba50"
checksum = "12598812502ed0105f607f941c386f43d441e00148fce9dec3ca5ffb0bde9308"
dependencies = [
"arbitrary",
"crc32fast",
"crossbeam-utils",
"displaydoc",
"flate2",
"indexmap",
"memchr",
"thiserror 2.0.12",
"time",
]
Loading
Loading