Subtree update of rust-analyzer

[lnicola]

r? @ghost

[rustbot]

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

[rustbot]

⚠️ Warning ⚠️

• This PR is based on an upstream commit that is 25 days old.

  It's recommended to update your branch according to the rustc_dev_guide.

[lnicola]

@bors r+ p=1 subtree sync

[bors]

📌 Commit 2147783 has been approved by lnicola

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2147783 with merge 28174fc...

[bors]

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 28174fc to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f8e9e76 (parent) -> 28174fc (this PR)

Test differences

Show 33255 test diffs

Stage 1

• asserting::capture_with_non_copyable_elem_has_correct_params: pass -> [missing] (J0)
• collections::btree::map::tests::test_extract_if::height_2_keeping_one: pass -> [missing] (J0)
• collections::vec_deque::tests::test_try_reserve: pass -> [missing] (J0)
• collections::vec_deque::tests::test_try_reserve_exact: pass -> [missing] (J0)
• error_formats_multi_line_with_rude_display_impl: pass -> [missing] (J0)
• f32::test_log10: pass -> [missing] (J0)
• floats::f128::test_zero: pass -> [missing] (J0)
• io::buffered::tests::line_write_all: pass -> [missing] (J0)
• iter::adapters::array_chunks::test_iterator_array_chunks_fold: pass -> [missing] (J0)
• iter::adapters::map_windows::drop_checks::len_equals_n: pass -> [missing] (J0)
• iter::adapters::map_windows::drop_checks::no_iter_panic_n1: pass -> [missing] (J0)
• iter::traits::iterator::test_iterator_last: pass -> [missing] (J0)
• mpsc::oneshot_single_thread_try_recv_closed: pass -> [missing] (J0)
• mpsc_sync::oneshot_single_thread_close_port_first: pass -> [missing] (J0)
• num::dec2flt::ordinary: pass -> [missing] (J0)
• num::i128::test_saturating_abs: pass -> [missing] (J0)
• num::i64::test_rotate: pass -> [missing] (J0)
• num::test_try_isizei128: pass -> [missing] (J0)
• num::test_try_isizeu32: pass -> [missing] (J0)
• panic::location::location_const_line: pass -> [missing] (J0)
• rwlock::test_rwlock_unsized: pass -> [missing] (J0)
• slice::slice_index::boundpair_overflow_start::pass: pass -> [missing] (J0)
• slice::test_iter_as_slice: pass -> [missing] (J0)
• slice::test_split_iterators_size_hint: pass -> [missing] (J0)
• string::test_from_iterator: pass -> [missing] (J0)
• sync::test_ptr_eq: pass -> [missing] (J0)
• test_ord: pass -> [missing] (J0)
• thin_box::align2full: pass -> [missing] (J0)
• vec::test_vec_dedup: pass -> [missing] (J0)
• config::externs::tests::test_split_extern_opt: pass -> [missing] (J1)
• error::verify_middle_layout_references_error_14: pass -> [missing] (J1)
• errors::verify_const_eval_raw_ptr_to_int_5: pass -> [missing] (J1)
• errors::verify_monomorphize_abi_required_target_feature_9: pass -> [missing] (J1)
• errors::verify_parse_const_let_mutually_exclusive_48: pass -> [missing] (J1)
• errors::verify_parse_invalid_offset_of_167: pass -> [missing] (J1)
• html::markdown::tests::test_ascii_with_prepending_hashtag: pass -> [missing] (J1)
• spec::tests::aarch64_apple_ios_sim: pass -> [missing] (J1)
• spec::tests::i686_pc_windows_msvc: pass -> [missing] (J1)
• spec::tests::riscv32imafc_unknown_none_elf: pass -> [missing] (J1)
• spec::tests::x86_64_unknown_redox: pass -> [missing] (J1)
• vec::tests::range_count_is_correct: pass -> [missing] (J1)
• ascii::is_ascii::unaligned_tail_medium::case02_align_to: pass -> [missing] (J2)
• ascii::short::is_ascii_lowercase: pass -> [missing] (J2)
• btree::map::clone_slim_100_and_drain_all: pass -> [missing] (J2)
• char::methods::bench_to_ascii_uppercase: pass -> [missing] (J2)
• net::tcp::tests::connect_loopback: pass -> [missing] (J2)
• num::int_sqrt::i32::isqrt_extended: pass -> [missing] (J2)
• sort::tests::stable::panic_retain_orig_set_string_random_s95: pass -> [missing] (J2)
• sort::tests::unstable::panic_observable_is_less_random: pass -> [missing] (J2)
• str::char_count::ru_large::case03_manual_char_len: pass -> [missing] (J2)
• str::split_space_char::long_lorem_ipsum: pass -> [missing] (J2)
• tests::filter_for_ignored_option: pass -> [missing] (J2)
• tests::test_bench_once_iter: pass -> [missing] (J2)
• vec::bench_extend_from_slice_0010_0010: pass -> [missing] (J2)
• sort::tests::stable::panic_observable_is_less_random_s95: ignore -> [missing] (J3)
• sort::tests::unstable::deterministic_string_random_d2: ignore -> [missing] (J3)

Stage 2

• collections::hash::set::tests::test_zero_capacities: [missing] -> pass (J0)
• cow_str::check_cow_add_assign_cow: [missing] -> pass (J0)
• create_dir_all_bare: [missing] -> pass (J0)
• io::error::tests::test_const: [missing] -> pass (J0)
• iter::traits::accum::test_iterator_product_option: [missing] -> pass (J0)
• iter::traits::iterator::test_iterator_nth: [missing] -> pass (J0)
• misc_tests::f64_slice: [missing] -> pass (J0)
• mpmc::test_recv_iter_break: [missing] -> pass (J0)
• num::dec2flt::parse::valid: [missing] -> pass (J0)
• num::int_log::ilog10_u16: [missing] -> pass (J0)
• num::test_u16f64: [missing] -> pass (J0)
• num::u128::test_isqrt: [missing] -> pass (J0)
• num::u64::test_midpoint: [missing] -> pass (J0)
• result::test_result_as_deref: [missing] -> pass (J0)
• slice::test_get_disjoint_mut_range_overlapping: [missing] -> pass (J0)
• slice::test_retain: [missing] -> pass (J0)
• str::slice_index::boundary::range_1::index_mut_fail: [missing] -> pass (J0)
• str::test_into_bytes: [missing] -> pass (J0)
• string::test_from_char: [missing] -> pass (J0)
• string::test_push: [missing] -> pass (J0)
• sys_common::wtf8::tests::wtf8buf_show: [missing] -> pass (J0)
• test_is_power_of_two_u16: [missing] -> pass (J0)
• thin_box::align64zst: [missing] -> pass (J0)
• vec::test_split_at_mut: [missing] -> pass (J0)
• vec_deque::test_binary_search: [missing] -> pass (J0)
• errors::verify_ast_passes_inherent_cannot_be_40: [missing] -> pass (J1)
• errors::verify_const_eval_mutable_raw_escaping_16: [missing] -> pass (J1)
• errors::verify_expand_feature_not_allowed_19: [missing] -> pass (J1)
• errors::verify_lint_unknown_tool_in_scoped_lint_0: [missing] -> pass (J1)
• errors::verify_parse_async_move_block_in_2015_69: [missing] -> pass (J1)
• errors::verify_passes_rustc_const_stable_indirect_pairing_174: [missing] -> pass (J1)
• errors::verify_passes_should_be_applied_to_fn_14: [missing] -> pass (J1)
• errors::verify_resolve_self_in_generic_param_default_10: [missing] -> pass (J1)
• html::render::ordered_json::tests::escape_json_array: [missing] -> pass (J1)
• server_impl::token_id::tests::test_ra_server_from_str: [missing] -> pass (J1)
• spec::tests::armv5te_unknown_linux_uclibceabi: [missing] -> pass (J1)
• spec::tests::thumbv7neon_unknown_linux_musleabihf: [missing] -> pass (J1)
• ascii::medium::is_ascii_alphanumeric: [missing] -> pass (J2)
• btree::map::iteration_mut_1000: [missing] -> pass (J2)
• iter::bench_next_chunk_trusted_random_access: [missing] -> pass (J2)
• iter::bench_partial_cmp: [missing] -> pass (J2)
• num::bench_u64_from_str: [missing] -> pass (J2)
• process::tests::test_override_env: [missing] -> pass (J2)
• sort::tests::unstable::stability_string_random: [missing] -> pass (J2)

(and 16557 additional test diffs)

Additionally, 16598 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
• J1: aarch64-apple, x86_64-apple-1
• J2: aarch64-apple, test-various, x86_64-apple-1
• J3: x86_64-gnu-aux

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 28174fc1a0525888615c8bce8f4ecec13c85ecc6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 4694.4s -> 1439.3s (-69.3%)
2. test-various: 4241.7s -> 2330.6s (-45.1%)
3. x86_64-gnu-aux: 5968.6s -> 4338.1s (-27.3%)
4. x86_64-apple-1: 6780.8s -> 8463.7s (24.8%)
5. dist-apple-various: 7975.2s -> 6145.8s (-22.9%)
6. aarch64-apple: 4340.6s -> 3657.2s (-15.7%)
7. x86_64-msvc-ext2: 6649.6s -> 5887.0s (-11.5%)
8. dist-x86_64-apple: 8980.3s -> 9497.0s (5.8%)
9. dist-armv7-linux: 5590.6s -> 5302.6s (-5.2%)
10. dist-aarch64-apple: 5937.4s -> 5641.2s (-5.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (28174fc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-5.4%, -0.5%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.4%, 0.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.9%, -0.4%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.927s -> 775.471s (-0.06%)
Artifact size: 365.55 MiB -> 365.50 MiB (-0.01%)