Construct OutputType using macro and print [=FILENAME] help info by xizheyin · Pull Request #140077 · rust-lang/rust

xizheyin · 2025-04-20T11:59:11Z

Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages.

On top of that, I optimized for emit help messages.

r? @jieyouxu

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

rustbot · 2025-04-20T11:59:17Z

This PR modifies run-make tests.

cc @jieyouxu

compiler/rustc_session/src/config.rs

tests/run-make/rustc-help/help.stdout

jieyouxu

Thanks, this looks like a nice improvement for --emit help. I left some nits.

compiler/rustc_session/src/config.rs

tests/run-make/rustc-help/help-v.stdout

tests/ui/invalid-compile-flags/emit-output-types-without-args.rs

compiler/rustc_session/src/config.rs

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

xizheyin · 2025-04-21T10:40:46Z

@rustbot ready

jieyouxu

Thanks

tests/run-make/rustc-help/help.stdout

jieyouxu · 2025-04-21T11:01:27Z

@rustbot author (for discussion)

rustbot · 2025-04-21T11:01:31Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jieyouxu · 2025-04-21T11:46:32Z

@bors r+ rollup

bors · 2025-04-21T11:46:35Z

📌 Commit 6fe881c has been approved by jieyouxu

It is now in the queue for this repository.

Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? `@jieyouxu`

Rollup of 12 pull requests Successful merges: - rust-lang#134213 (Stabilize `naked_functions`) - rust-lang#139795 (Clarify why SGX code specifies linkage/symbol names for certain statics) - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140036 (Advent of `tests/ui` (misc cleanups and improvements) [4/N]) - rust-lang#140047 (remove a couple clones) - rust-lang#140052 (Fix error when an intra doc link is trying to resolve an empty associated item) - rust-lang#140074 (rustdoc-json: Improve test for auto-trait impls) - rust-lang#140076 (jsondocck: Require command is at start of line) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140091 (build_helper: try to rename dir before delete) - rust-lang#140107 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? ``@jieyouxu``

…enton Rollup of 4 pull requests Successful merges: - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140128 (Use correct annotation for CSS pseudo elements) r? `@ghost` `@rustbot` modify labels: rollup

…enton Rollup of 5 pull requests Successful merges: - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140094 (Improve diagnostics for pointer arithmetic += and -= (fixes rust-lang#137391)) - rust-lang#140128 (Use correct annotation for CSS pseudo elements) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#140077 - xizheyin:issue-139805, r=jieyouxu Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? ```@jieyouxu```

Add ui test emit-output-types-without-args.rs

4c20d17

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

rustbot assigned jieyouxu Apr 20, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2025

This comment has been minimized.

Sign in to view

xizheyin force-pushed the issue-139805 branch from aca2170 to bfceb19 Compare April 20, 2025 13:10

clubby789 reviewed Apr 20, 2025

View reviewed changes

compiler/rustc_session/src/config.rs Outdated Show resolved Hide resolved

clubby789 reviewed Apr 20, 2025

View reviewed changes

compiler/rustc_session/src/config.rs Show resolved Hide resolved

clubby789 reviewed Apr 20, 2025

View reviewed changes

tests/run-make/rustc-help/help.stdout Outdated Show resolved Hide resolved

xizheyin force-pushed the issue-139805 branch from bfceb19 to cb2802b Compare April 21, 2025 03:56

jieyouxu requested changes Apr 21, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2025

jieyouxu mentioned this pull request Apr 21, 2025

Consider unifying how rustc cli flag values are presented #140102

Open

Construct OutputType using macro and print [=FILENAME] help info

6fe881c

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

xizheyin force-pushed the issue-139805 branch from cb2802b to 6fe881c Compare April 21, 2025 10:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 21, 2025

jieyouxu approved these changes Apr 21, 2025

View reviewed changes

jieyouxu reviewed Apr 21, 2025

View reviewed changes

tests/run-make/rustc-help/help.stdout Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2025

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 21, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2025

jieyouxu mentioned this pull request Apr 21, 2025

Rollup of 12 pull requests #140112

Closed

ChrisDenton mentioned this pull request Apr 21, 2025

Rollup of 4 pull requests #140134

Closed

ChrisDenton mentioned this pull request Apr 22, 2025

Rollup of 5 pull requests #140138

Merged

xizheyin mentioned this pull request Apr 22, 2025

Unify the format of rustc cli flags #140152

Merged

bors merged commit 2fff825 into rust-lang:master Apr 22, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 22, 2025

Uh oh!

Conversation

xizheyin commented Apr 20, 2025

Uh oh!

rustbot commented Apr 20, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xizheyin commented Apr 21, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Apr 21, 2025

Uh oh!

rustbot commented Apr 21, 2025

Uh oh!

jieyouxu commented Apr 21, 2025

Uh oh!

bors commented Apr 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants