Skip to content

DRAFT: Add an aarch64-msvc build running on ARM64 Windows #126341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DRAFT: Add an aarch64-msvc build running on ARM64 Windows #126341

wants to merge 1 commit into from

Conversation

@dpaoliello
Copy link
Contributor

r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 12, 2024
@dpaoliello dpaoliello force-pushed the arm64winci branch 2 times, most recently from 4415333 to fd96071 Compare June 12, 2024 17:36
@dpaoliello
Copy link
Contributor Author

Looks like this is blocked by msys2/setup-msys2#358

@dpaoliello
Copy link
Contributor Author

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024
@dpaoliello dpaoliello force-pushed the arm64winci branch 2 times, most recently from 75f4b93 to 1af7d34 Compare June 13, 2024 18:36
@ChrisDenton
Copy link
Member

The msys2 setup step was discussed recently and it was concluded that it could possibly be skipped if you can manually get the mingw make earlier in PATH than the default make. Though you'd also need to make sure not to override other tools.

run-make tests specifically need the one that uses mingw style paths.

@dpaoliello dpaoliello force-pushed the arm64winci branch 11 times, most recently from 8f57e7a to c2802f8 Compare June 13, 2024 22:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dpaoliello
Copy link
Contributor Author

Looks like this is blocked by msys2/setup-msys2#358

I've worked around this by downgrading the setup-msys2 task to v2.21.0

The bigger issue that I'm hitting now: this is a clean install of Windows, so no VS, Git, GitHub Runner Agent, etc.

@Kobzol
Copy link
Member

Kobzol commented Jun 14, 2024

The bigger issue that I'm hitting now: this is a clean install of Windows, so no VS, Git, GitHub Runner Agent, etc.

Does that somehow differ on ARM vs the old x86 Windows runners?

@dpaoliello
Copy link
Contributor Author

The bigger issue that I'm hitting now: this is a clean install of Windows, so no VS, Git, GitHub Runner Agent, etc.

Does that somehow differ on ARM vs the old x86 Windows runners?

Yes: the x86 runners use a pre-built image provided by GitHub, but GitHub/Microsoft are yet to provide such an image for ARM64 Windows. GitHub's blog post says "with plans to add developer tools to the Windows image" but doesn't provide any timeline for when that'll be available.

I'm going to continue to experiment with installing dependencies during the build, but it may take me a while to get everything working.

@dpaoliello dpaoliello force-pushed the arm64winci branch 2 times, most recently from d9e0359 to e3c2f4d Compare June 14, 2024 22:24
@dpaoliello
Copy link
Contributor Author

I'm going to pause this work until there's a Windows ARM64 image with tools preinstalled.

@dpaoliello dpaoliello closed this Jun 21, 2024
@dpaoliello dpaoliello mentioned this pull request Apr 21, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2025
@bors
Auto merge of rust-lang#140136 - dpaoliello:arm64winci, r=<try>
b41c332 
DRAFT: Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

r? `@Kobzol`

try-job: `*aarch64-msvc*`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2025
@bors
Auto merge of rust-lang#140136 - dpaoliello:arm64winci, r=<try>
c886c51 
DRAFT: Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

r? `@Kobzol`

try-job: `*aarch64-msvc*`
rust-bors bot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of #140136 - dpaoliello:arm64winci, r=<try>
e5a36c5 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting #126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
rust-bors bot added a commit that referenced this pull request Jun 19, 2025
@rust-bors
Auto merge of #140136 - dpaoliello:arm64winci, r=<try>
85d00de 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting #126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 22, 2025
@jhpratt
Rollup merge of rust-lang#140136 - dpaoliello:arm64winci, r=Kobzol
06c4f56 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 10, 2025
@tgross35
Rollup merge of rust-lang#140136 - dpaoliello:arm64winci, r=Kobzol
a37b01d 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 11, 2025
@tgross35
Rollup merge of rust-lang#140136 - dpaoliello:arm64winci, r=Kobzol
6debe03 
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? ``@Kobzol``

try-job: `*aarch64-msvc*`
rust-timer added a commit that referenced this pull request Jul 11, 2025
@rust-timer
Unrolled build for #140136
90ed755 
Rollup merge of #140136 - dpaoliello:arm64winci, r=Kobzol

Add an aarch64-msvc build running on ARM64 Windows

Resurrecting #126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? ``@Kobzol``

try-job: `*aarch64-msvc*`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dpaoliello @ChrisDenton @rust-log-analyzer @Kobzol @rustbot