RFC: Promote aarch64-pc-windows-msvc to Tier 1 #3817
Conversation
dpaoliello
force-pushed
the
aarch64tier1
branch
2 times, most recently
from
9594548 to
359127e
Compare
| [ci-draft-pr][https://github.com/rust-lang/rust/pull/140136] | ||
| [llvm-builders][https://lab.llvm.org/buildbot/#/builders/161] | ||
| [platform-support][https://github.com/rust-lang/rust/blob/e3892a40a9d06034fdf2432a9d3d29fa97726299/src/doc/rustc/src/platform-support.md?plain=1#:~:text=aarch64%2Dpc%2Dwindows%2Dmsvc] | ||
| [promote-tier-2][https://github.com/rust-lang/rust/pull/75914] |
There was a problem hiding this comment.
The syntax for link definitions needs to have a colon and look like:
[link-name]: https://example.com/
|
|
||
| > The target maintainer team must include at least 3 developers. | ||
|
|
||
| There is an existing [Windows team for Rust][windows-team] and, within Microsoft, Arm64 Windows is |
There was a problem hiding this comment.
Are there at least 3 people in that group that are willing to be active maintainers for this particular target? It seems like we should identify who those people will be.
The windows marker team is mainly just a ping group and not necessarily maintainers (anyone can be added to it).
There was a problem hiding this comment.
Problem (blocking): Yeah, Tier 1 target policy requires
The target maintainer team must include at least 3 developers.
The "windows" ping group is advisory at best, it is not even specific to the other Tier 1 x86_64-pc-windows-msvc or x86_64-pc-windows-gnu targets1.
On the compiler team, we lack expertise bandwidth on the Tier 1 Windows targets already. Furthermore, to the best of my knowledge, very few (if any) compiler team members have access to a aarch64-pc-windows-msvc host, be it natively or remotely. This makes even "routine" tasks like triaging or bisection or minimizations very difficult, so for a Tier 1 target, we would have to rely on its target maintainers perhaps more than is the case for other Tier 1 targets.
Footnotes
-
In fact, those Tier 1 targets don't technically adhere to our current Target Policy, because they were grandfathered in historically (it obviously made sense at the time, and still does now), but the compiler team would like to have actual dedicated target maintainers for the other Tier 1 Windows targets too going forward. ↩
There was a problem hiding this comment.
Fair enough: let me talk to a few folks internally, I'd like to get an official *-pc-windows-msvc maintainer list setup for the various Windows targets.
|
|
||
| > All requirements for tier 2 apply. | ||
|
|
||
| [`aarch64-pc-windows-msvc` is already a Tier 2 target.][platform-support] |
There was a problem hiding this comment.
AFAIK aarch64-pc-windows-msvc was grandfathered into the tier policy without having its requirements verified. I don't think there is anything particularly noteworthy, but I think it would probably be good to not gloss over them.
There was a problem hiding this comment.
The aarch64 windows target is listed on rust-lang/rust#113739 because it does not currently have any target maintainers listed. So yes, there is something quite noteworthy here. We should really go over that entire checklist.
There was a problem hiding this comment.
Ok, expanded with the relevant points from Tier 2.
ehuss
added
T-compiler
|
related: promoting |
Rendered