Skip to content

Rollup of 10 pull requests #110852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 26, 2023
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b0a7d6e
Suggest deref on comparison binop RHS even if type is not Copy
compiler-errors Apr 19, 2023
1c3efc6
Add new rustdoc book chapter to describe in-doc settings
GuillaumeGomez Apr 21, 2023
f56b6d0
pass `unused_extern_crates` in `librustdoc::doctest::make_test`
onur-ozkan Apr 25, 2023
eeb5276
Add deny lint to prevent untranslatable diagnostics using static strings
clubby789 Mar 5, 2023
0138513
Fix static string lints
clubby789 Apr 10, 2023
451e86c
simplify TrustedLen impls
tamird Apr 25, 2023
1bfbac7
diagnostics: add test case for already-solved issue
notriddle Apr 25, 2023
8216b7f
Make some region folders a little stricter.
nnethercote Apr 26, 2023
9cb9346
Spelling library/
jsoref Apr 11, 2023
1042b2c
rewrite: long_line_flushed description
jsoref Apr 19, 2023
9a55e9e
rewrite: line_long_tail_not_flushed description
jsoref Apr 19, 2023
b311ec0
Try to improve tidy errors on TODOs
WaffleLapkin Mar 21, 2023
2b7dd08
rustdoc-json: Time serialization.
aDotInTheVoid Apr 26, 2023
309496c
Rollup merge of #108760 - clubby789:autolintstuff, r=wesleywiser
matthiaskrgr Apr 26, 2023
ea8bd06
Rollup merge of #109444 - WaffleLapkin:undeprecate_todos, r=jyn514
matthiaskrgr Apr 26, 2023
9babe98
Rollup merge of #110419 - jsoref:spelling-library, r=jyn514
matthiaskrgr Apr 26, 2023
8e6fffc
Rollup merge of #110550 - compiler-errors:deref-on-binop-rhs, r=wesle…
matthiaskrgr Apr 26, 2023
66a5ac0
Rollup merge of #110641 - GuillaumeGomez:rustdoc-in-doc-settings, r=n…
matthiaskrgr Apr 26, 2023
1d73549
Rollup merge of #110798 - ozkanonur:rustdoc-unused-extern-crates, r=j…
matthiaskrgr Apr 26, 2023
8fe7a49
Rollup merge of #110819 - tamird:flattencompat-trustedlen, r=the8472
matthiaskrgr Apr 26, 2023
bcd55ce
Rollup merge of #110825 - notriddle:notriddle/issue-70082, r=compiler…
matthiaskrgr Apr 26, 2023
e47562c
Rollup merge of #110835 - nnethercote:strict-region-folders-2, r=comp…
matthiaskrgr Apr 26, 2023
63bccce
Rollup merge of #110847 - aDotInTheVoid:rdj-time-serialization, r=Gui…
matthiaskrgr Apr 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/tools/tidy/src/style.rs
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,12 @@ pub fn check(path: &Path, bad: &mut bool) {
}
if filename != "style.rs" {
if trimmed.contains("TODO") {
err("TODO is deprecated; use FIXME")
err(
"TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME",
)
}
if trimmed.contains("//") && trimmed.contains(" XXX") {
err("XXX is deprecated; use FIXME")
err("Instead of XXX use FIXME")
}
if any_problematic_line {
for s in problematic_consts_strings.iter() {
Expand Down