Rollup of 10 pull requests #110852

matthiaskrgr · 2023-04-26T16:51:45Z

Successful merges:

Add lint to deny diagnostics composed of static strings #108760 (Add lint to deny diagnostics composed of static strings)
Change tidy error message for TODOs #109444 (Change tidy error message for TODOs)
Spelling library #110419 (Spelling library)
Suggest deref on comparison binop RHS even if type is not Copy #110550 (Suggest deref on comparison binop RHS even if type is not Copy)
Add new rustdoc book chapter to describe in-doc settings #110641 (Add new rustdoc book chapter to describe in-doc settings)
pass unused_extern_crates in librustdoc::doctest::make_test #110798 (pass unused_extern_crates in librustdoc::doctest::make_test)
simplify TrustedLen impls #110819 (simplify TrustedLen impls)
diagnostics: add test case for already-solved issue #110825 (diagnostics: add test case for already-solved issue)
Make some region folders a little stricter. #110835 (Make some region folders a little stricter.)
rustdoc-json: Time serialization. #110847 (rustdoc-json: Time serialization.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Signed-off-by: ozkanonur <work@onurozkan.dev>

Implement on FlattenCompat and delegate from Flatten and FlatMap.

Fixes rust-lang#70082

Because certain regions cannot occur in them.

* advance * aligned * borrowed * calculate * debugable * debuggable * declarations * desugaring * documentation * enclave * ignorable * initialized * iterator * kaboom * monomorphization * nonexistent * optimizer * panicking * process * reentrant * rustonomicon * the * uninitialized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

…iser Add lint to deny diagnostics composed of static strings r? ghost I'm hoping to have a lint that semi-automatically converts simple diagnostics such as `struct_span_err(span, "msg").help("msg").span_note(span2, "msg").emit()` to typed session diagnostics. It's quite hacky and not entirely working because of problems with `x fix` but should hopefully help reduce some of the work. I'm going to start trying to apply what I can from this, but opening this as a draft in case anyone wants to develop on it. cc rust-lang#100717

…jyn514 Change tidy error message for TODOs Blocked on rust-lang#109440 (first few commits are from where) IMO "deprecated" doesn't really explain anything, I've tried to highlight the actual reason we error on TODOs. The message is not at all perfect, maybe someone has ideas how to phrase it better?

Spelling library Split per rust-lang#110392 I can squash once people are happy w/ the changes. It's really uncommon for large sets of changes to be perfectly acceptable w/o at least some changes. I probably won't have time to respond until tomorrow or the next day

…, r=wesleywiser Suggest deref on comparison binop RHS even if type is not Copy Fixes rust-lang#110500

…ings, r=notriddle Add new rustdoc book chapter to describe in-doc settings Fixes rust-lang#55165. I continue going through old rustdoc issues. This one made a lot of sense so decided to add the missing chapter. r? ``@notriddle``

…ates, r=jyn514 pass `unused_extern_crates` in `librustdoc::doctest::make_test` blocker for rust-lang#106621

…=the8472 simplify TrustedLen impls Implement on FlattenCompat and delegate from Flatten and FlatMap. /cc ``@the8472``

…=compiler-errors diagnostics: add test case for already-solved issue Fixes rust-lang#70082

…2, r=compiler-errors Make some region folders a little stricter. Because certain regions cannot occur in them. r? ``@compiler-errors``

…on, r=GuillaumeGomez rustdoc-json: Time serialization. This lets us know how much time is spent in json specific code, and how much performance we could gain by using a different serialization format. For aws-sdk-ec2, it takes 0.7s, out of a 43s build (of which 6s is spent in json specific code), and makes a 173M json file ``` $ cargo +rust_stage2 rustdoc -p aws-sdk-ec2 -- -Zunstable-options -w json -Ztime-passes Documenting aws-sdk-ec2 v0.26.0 (/home/gh-aDotInTheVoid/aws-sdk-rust/sdk/ec2) time: 5.229; rss: 64MB -> 891MB ( +827MB) expand_crate time: 5.230; rss: 61MB -> 891MB ( +830MB) macro_expand_crate time: 0.256; rss: 891MB -> 891MB ( +0MB) AST_validation time: 0.025; rss: 891MB -> 891MB ( +1MB) finalize_imports time: 0.093; rss: 891MB -> 891MB ( +0MB) compute_effective_visibilities time: 0.122; rss: 891MB -> 891MB ( +0MB) finalize_macro_resolutions time: 2.442; rss: 891MB -> 1188MB ( +297MB) late_resolve_crate time: 0.120; rss: 1188MB -> 1190MB ( +2MB) resolve_check_unused time: 0.211; rss: 1190MB -> 1190MB ( +0MB) resolve_postprocess time: 3.017; rss: 891MB -> 1190MB ( +299MB) resolve_crate time: 8.520; rss: 61MB -> 1181MB (+1120MB) prepare_outputs time: 0.152; rss: 1181MB -> 1181MB ( +0MB) complete_gated_feature_checking time: 0.539; rss: 1633MB -> 1632MB ( -1MB) drop_ast time: 15.492; rss: 58MB -> 1621MB (+1563MB) type_collecting time: 1.503; rss: 1621MB -> 1705MB ( +84MB) item_types_checking time: 1.274; rss: 1705MB -> 1726MB ( +21MB) crate_lints time: 1.275; rss: 1705MB -> 1726MB ( +21MB) missing_docs time: 0.281; rss: 1726MB -> 1726MB ( +0MB) check_mod_attrs time: 0.433; rss: 1744MB -> 1750MB ( +6MB) clean_crate time: 11.581; rss: 1750MB -> 2107MB ( +357MB) collect_synthetic_impls time: 0.019; rss: 2107MB -> 2107MB ( +0MB) collect_items_for_trait_impls time: 12.588; rss: 1750MB -> 2139MB ( +389MB) collect-trait-impls time: 0.197; rss: 2139MB -> 2139MB ( +0MB) check_doc_test_visibility time: 0.281; rss: 2139MB -> 2150MB ( +11MB) strip-hidden time: 0.260; rss: 2150MB -> 2150MB ( +0MB) strip-private warning: unresolved link to `date` --> sdk/ec2/src/client/describe_instances.rs:7:11184 | 7 | ...te of the instance (for example, shows "User Initiated [date]" when you stop or terminate the instance). Similar to the state-reason-code filter.<... | ^^^^ no item named `date` in scope | = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]` = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default time: 0.363; rss: 2150MB -> 2150MB ( +0MB) collect-intra-doc-links time: 0.946; rss: 2150MB -> 2150MB ( +0MB) propagate-doc-cfg time: 0.494; rss: 2150MB -> 2152MB ( +2MB) run-lints time: 0.658; rss: 2152MB -> 2163MB ( +11MB) create_format_cache time: 34.818; rss: 58MB -> 2163MB (+2105MB) run_global_ctxt time: 0.016; rss: 2163MB -> 2163MB ( +0MB) create_renderer(json) time: 0.723; rss: 2780MB -> 2780MB ( +0MB) rustdoc_json_serialization time: 2.216; rss: 2399MB -> 2599MB ( +199MB) renderer_after_krate(json) time: 6.639; rss: 2163MB -> 2417MB ( +254MB) render_json time: 0.312; rss: 2417MB -> 2071MB ( -346MB) free_global_ctxt warning: `aws-sdk-ec2` (lib doc) generated 1 warning Finished dev [unoptimized + debuginfo] target(s) in 43.06s ``` [(Zulip Discussion)](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/JSON.20metadata.20speed/near/352783145) r? `@GuillaumeGomez`

matthiaskrgr · 2023-04-26T16:52:02Z

@bors r+ rollup=never p=10

bors · 2023-04-26T16:52:05Z

📌 Commit 63bccce has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-04-26T18:33:00Z

⌛ Testing commit 63bccce with merge 1c42cb4...

bors · 2023-04-26T21:42:07Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 1c42cb4 to master...

rust-timer · 2023-04-26T21:44:57Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#110847	de1f24d5eaa30897b80a6e64b13c039ed0529410
#110835	8e20d40994195d763b18e32bf37cf204289a7eca
#110825	54fd5ffd3f37f7e56ae38ac169b8b07bf0416223
#110819	50914bc9edde02c57f1c8dae777965a7c4dd5858
#110798	64cec96f9491f5599adedda645c72370e6515301
#110641	5656a2d53f612a47925b3413555a51985004e3f7
#110550	42f2bef19a784284e02a7c99e9326161e7f03949
#110419	f76c308434bc7acc01cd5f7a41a9daca40680959
#109444	a9481ef7041a4a6cc8cb248bc78274088be680c0
#108760	34bfa438e49d80d371dac102f766f7f551a780bb

previous master: 9c044d77a3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-26T22:58:27Z

Finished benchmarking commit (1c42cb4): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.4%]	4
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-0.4%	[-0.5%, -0.4%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

compiler-errors and others added 23 commits April 19, 2023 16:47

Suggest deref on comparison binop RHS even if type is not Copy

b0a7d6e

Add new rustdoc book chapter to describe in-doc settings

1c3efc6

pass unused_extern_crates in librustdoc::doctest::make_test

f56b6d0

Signed-off-by: ozkanonur <work@onurozkan.dev>

Add deny lint to prevent untranslatable diagnostics using static strings

eeb5276

Fix static string lints

0138513

simplify TrustedLen impls

451e86c

Implement on FlattenCompat and delegate from Flatten and FlatMap.

diagnostics: add test case for already-solved issue

1bfbac7

Fixes rust-lang#70082

Make some region folders a little stricter.

8216b7f

Because certain regions cannot occur in them.

rewrite: long_line_flushed description

1042b2c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

rewrite: line_long_tail_not_flushed description

9a55e9e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Try to improve tidy errors on TODOs

b311ec0

rustdoc-json: Time serialization.

2b7dd08

Rollup merge of rust-lang#110550 - compiler-errors:deref-on-binop-rhs…

8e6fffc

…, r=wesleywiser Suggest deref on comparison binop RHS even if type is not Copy Fixes rust-lang#110500

Rollup merge of rust-lang#110798 - ozkanonur:rustdoc-unused-extern-cr…

1d73549

…ates, r=jyn514 pass `unused_extern_crates` in `librustdoc::doctest::make_test` blocker for rust-lang#106621

Rollup merge of rust-lang#110819 - tamird:flattencompat-trustedlen, r…

8fe7a49

…=the8472 simplify TrustedLen impls Implement on FlattenCompat and delegate from Flatten and FlatMap. /cc ``@the8472``

Rollup merge of rust-lang#110825 - notriddle:notriddle/issue-70082, r…

bcd55ce

…=compiler-errors diagnostics: add test case for already-solved issue Fixes rust-lang#70082

Rollup merge of rust-lang#110835 - nnethercote:strict-region-folders-…

e47562c

…2, r=compiler-errors Make some region folders a little stricter. Because certain regions cannot occur in them. r? ``@compiler-errors``

rustbot added WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Apr 26, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 26, 2023

bors merged commit 1c42cb4 into rust-lang:master Apr 26, 2023

rustbot added this to the 1.71.0 milestone Apr 26, 2023

matthiaskrgr deleted the rollup-jz3eosr branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #110852

Rollup of 10 pull requests #110852

Uh oh!

matthiaskrgr commented Apr 26, 2023

Uh oh!

matthiaskrgr commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

rust-timer commented Apr 26, 2023

Uh oh!

rust-timer commented Apr 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Rollup of 10 pull requests #110852

Rollup of 10 pull requests #110852

Uh oh!

Conversation

matthiaskrgr commented Apr 26, 2023

Uh oh!

matthiaskrgr commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

bors commented Apr 26, 2023

Uh oh!

rust-timer commented Apr 26, 2023

Uh oh!

rust-timer commented Apr 26, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants