Skip to content

Add a rustc-dev-guide chapter #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add a rustc-dev-guide chapter #873

merged 1 commit into from
Jun 5, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Jun 3, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2025
@BoxyUwU BoxyUwU mentioned this pull request Jun 3, 2025
Open
tshepang
tshepang reviewed Jun 3, 2025
View reviewed changes
jieyouxu
jieyouxu reviewed Jun 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 🩵 I have a few suggestions and discussion points.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 4, 2025

r? jieyouxu
@rustbot author

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Jun 4, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@jieyouxu jieyouxu mentioned this pull request Jun 4, 2025
Open
2 tasks
jieyouxu
jieyouxu approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one last nit

@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025

Feel free to r=me if new wording resolves @tshepang's concern.

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jun 5, 2025

I don't think I can actually merge things to forge until rust-lang/team#1864 is merged.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025 •
edited
Loading

I don't think I can actually merge things to forge until rust-lang/team#1864 is merged.

Wait what, you must have write perms at the minimum from being part of compiler and release (at least). It's just an outstanding comment that was not resolved, right?

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Jun 5, 2025

Oh yeah I can lol :D

@BoxyUwU BoxyUwU merged commit 0f9b8a5 into master Jun 5, 2025
1 check passed
@BoxyUwU BoxyUwU deleted the dev-guide-page branch June 5, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BoxyUwU @rustbot @jieyouxu @tshepang @Mark-Simulacrum