-
Notifications
You must be signed in to change notification settings - Fork 191
Add Archive of Rust Stable Standalone Installers #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Archive of Rust Stable Standalone Installers #733
Conversation
r? @shepmaster |
1cb6b77
to
db4255e
Compare
6f58568
to
c848983
Compare
r? @ehuss |
@ehuss thanks a lot for taking a look. I addressed your feedback. |
Yeah, thanks a lot! It could be nice to have a matrix instead (but that makes it complex, i.e. empty cases would need to be handled, plus it may be not great scrolling horizontally, so it could require breaking the table in several anyway), or a selector, or at least a way to jump quickly to the right version. But I would not worry about any of that -- even if it is just a dump of links, it is useful :) |
I am not on the infra or release teams, so I'm not sure I am the appropriate person to be approving things on their behalf. Perhaps @Mark-Simulacrum would give the green light. I'm fine with the implementation barring #733 (comment) getting resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me with one implementation and one wording note.
c848983
to
3dbcfd5
Compare
@Mark-Simulacrum Do you mind taking another look when you get a chance? Thanks. |
Could you remove the merge commits please? |
ab13eed
to
771066c
Compare
@Kobzol done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous comments have been resolved, so I think that we can merge this.
Closes #676
This PR adds a new page "Archive of Rust Stable Standalone Installers" that contains a list of tables of previous stable Rust version standalone installers.
Currently it works for all versions > 1.8. Versions <= 1.7 do not have v2 toml manifests. See Zulip for details.
@shepmaster @ojeda Is this what you had in mind?
Screenshots: