Deduplicate entries in the archive of stable standalone installers #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @Kobzol |
yerke
force-pushed
the
yerke/deduplicate-archive-stable-installers
branch
from
9ca84b3 to
a383e36
Compare
Kobzol
approved these changes
Oct 15, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Archive of Rust Stable Standalone Installers page in #733.
Later it was pointed out to me that version 1.8.0 is listed twice on the archive page. My original implementation relied on my assumption that
https://static.rust-lang.org/dist/YYYY-MM-DD/channel-rust-1.minor.patch.tomlwould appear only once in the https://static.rust-lang.org/manifests.txt. (It seems fine at a glance when I was implementing it.) But that is not true for 1.8.0, 1.14.0, 1.15.1, 1.49.0, which have multiple entries.In this PR I add logic to deduplicate entries in the archive of stable standalone installers and make sure that they are printed in the correct order.
Screenshot that shows the duplicate entries before this PR:
