Skip to content

add tests for using macros in as_conversions_lint #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion tests/ui/as_conversions.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,23 @@
#[warn(clippy::as_conversions)]
#![warn(clippy::as_conversions)]

macro_rules! mcr1 {
(0_u32 as u64) => {
()
};
}

macro_rules! mcr2 {
() => {
0_u32 as u64
};
}

fn main() {
let i = 0u32 as u64;

let j = &i as *const u64 as *mut u64;

let k = mcr1!(0_u32 as u64);

let p = mcr2!();
}
19 changes: 15 additions & 4 deletions tests/ui/as_conversions.stderr
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: using a potentially dangerous silent `as` conversion
--> $DIR/as_conversions.rs:4:13
--> $DIR/as_conversions.rs:16:13
|
LL | let i = 0u32 as u64;
| ^^^^^^^^^^^
Expand All @@ -8,20 +8,31 @@ LL | let i = 0u32 as u64;
= help: consider using a safe wrapper for this conversion

error: using a potentially dangerous silent `as` conversion
--> $DIR/as_conversions.rs:6:13
--> $DIR/as_conversions.rs:18:13
|
LL | let j = &i as *const u64 as *mut u64;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider using a safe wrapper for this conversion

error: using a potentially dangerous silent `as` conversion
--> $DIR/as_conversions.rs:6:13
--> $DIR/as_conversions.rs:18:13
|
LL | let j = &i as *const u64 as *mut u64;
| ^^^^^^^^^^^^^^^^
|
= help: consider using a safe wrapper for this conversion

error: aborting due to 3 previous errors
error: using a potentially dangerous silent `as` conversion
--> $DIR/as_conversions.rs:11:9
|
LL | 0_u32 as u64
| ^^^^^^^^^^^^
...
LL | let p = mcr2!();
| ------- in this macro invocation
|
= help: consider using a safe wrapper for this conversion

error: aborting due to 4 previous errors