Skip to content

add tests for using macros in as_conversions_lint #4888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add tests for using macros in as_conversions_lint #4888

wants to merge 1 commit into from

Conversation

basil-cow
Copy link
Contributor

As somebody noted in the original pr (unfortunately only after it was closed), as_conversions lint needs macro interaction tests. Also I am not sure whether or not we should lint in the local macro invocations (currently we are linting in them).

@llogiq
Copy link
Contributor

llogiq commented Dec 7, 2019

How about external macros? All the macros tested here are local.

Otherwise this seems like a good idea and we might as well merge as is and iterate later if you like.

@basil-cow
Copy link
Contributor Author

Can you point to a lint with external macro tests? I don't really know how to use external crates in tests.

@krishna-veerareddy
Copy link
Contributor

krishna-veerareddy commented Dec 8, 2019 •
edited
Loading

@Areredify Hey I had to add an external macro test for a new lint recently so maybe this could help you: #4881. Specifically files: tests/ui/mem_replace.rs and tests/ui/auxiliary/macro_rules.rs

@basil-cow
Copy link
Contributor Author

@krishna-veerareddy oh, that's how you do it, thanks

@phansch
Copy link
Member

phansch commented Dec 13, 2019

@Areredify Do you still want to add the external macro tests? Let me know if you need further help =)

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Dec 13, 2019
@phansch
Copy link
Member

phansch commented Jan 24, 2020 •
edited
Loading

@Areredify friendly ping wrt. the external macro tests =)

@phansch
Copy link
Member

phansch commented Apr 15, 2020

Hi @Areredify, I'm going ahead and close this PR as it hasn't been active in a while. Please don't hesitate to re-open it or ask for help when you want to pick it up again =)

@phansch phansch closed this Apr 15, 2020
@phansch phansch added the S-inactive-closed Status: Closed due to inactivity label Apr 15, 2020
@chansuke
Copy link
Contributor

I want to add external macros

@chansuke chansuke mentioned this pull request Nov 10, 2020
Merged
bors added a commit that referenced this pull request Nov 21, 2020
@bors
Auto merge of #6317 - chansuke:add-external-macro, r=llogiq
e23b087 
Add exteranal macros for as_conversions

Added external macros to this PR #4888.

r? `@llogiq`
bors added a commit that referenced this pull request Nov 23, 2020
@bors
Auto merge of #6317 - chansuke:add-external-macro, r=llogiq
eaeb3c0 
Add exteranal macros for as_conversions

Added external macros to this PR #4888.

r? `@llogiq`
bors added a commit that referenced this pull request Nov 23, 2020
@bors
Auto merge of #6317 - chansuke:add-external-macro, r=llogiq
723ac0f 
Add exteranal macros for as_conversions

Added external macros to this PR #4888.

r? `@llogiq`

changelog: none
@HKalbasi
Copy link
Member

finished in #6317
@rustbot label -S-inactive-closed -S-waiting-on-author

@rustbot rustbot removed S-inactive-closed Status: Closed due to inactivity S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@basil-cow @llogiq @krishna-veerareddy @phansch @chansuke @HKalbasi @rustbot