Remove inlay hint in diff views #3388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the left side of a diff view that contain the old version of the file apply inlays they are misplaced. The detection is done by blacklisting the url schemes used by git and subversion scm extensions.
lnicola
reviewed
Mar 1, 2020
editors/code/src/inlay_hints.ts
Outdated
| @@ -90,7 +92,14 @@ class HintsUpdater { | |||
|
|
|||
| private get allEditors(): vscode.TextEditor[] { | |||
| return vscode.window.visibleTextEditors.filter( | |||
| editor => editor.document.languageId === 'rust', | |||
| editor => { | |||
| if (editor.document.languageId !== 'rust') { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Reading a little bit more code I think i'll also change & share code with |
|
Yeah, makes sense. I wonder if we should maybe also lift |
Also move visibleRustEditors to Ctx
|
Done, I also made the check a separate function in |
|
bors r+ Thanks! |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the left side of a diff view that contain the old version of the file apply inlays they are misplaced and produce a weird display:
After the change:
The detection is done by blacklisting the url schemes used by git and subversion scm extensions, whitelisting
fileis also possible but neither is perfect as VSCode now support both pluggable scm extensions and pluggable remote filesystems. But I suspect that the list of scm extensions is more easily manageable.Note: I can rebase on #3378 if needed as it touches the same lines of code