Remove inlay hint in diff views

[jasonwilliams]

Using Github Pull Requests plugin i open the diff view and have the inline hints being messed up.

I'm guessing the best solution is to not show hints in the diff view

VSCode Version
1.46 insiders

RA Version
v0.2.182

Screenshot

It looks like this issue was brought up before so i don't know if there's some easy solution.
Similar to #3388

[Veetaha]

Thanks for the report, will try to look into this, the fix should be trivial.
In the meantime, if you are using nightly builds of rust-analyzer, you can try assigning a keyboard shortcut for turning off the inlay hints as demoed in this PR: #4601

[Veetaha]

Unfortunately the fix is non-trivial. The document scheme of Github PR extension diff view is file which basically means it is indistinctive from a regular rust source file.

As you can see in debug output, there are two editors with two documents, but the bad news is that one of them has file scheme (the editor with current changes), while the other one has preview scheme. With the following PR I only fixed the left side of the diff view, the right side will proceed displaying the inlay hints...

see #4625

[lnicola]

I think this is better now?

The hints still show up in some cases, but they're not that annoying:

@jasonwilliams can you please retest?

[Veykril]

I don't think this is something we can reasonably fix as we are not aware of diffs, if anything I feel like VSCode should allow to hide inlay-hints in the diff view