Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Complete italian translation #678

Merged
merged 10 commits into from
Jan 16, 2017
Merged

Complete italian translation #678

merged 10 commits into from
Jan 16, 2017

Conversation

gabibbo97
Copy link
Contributor

@gabibbo97 gabibbo97 commented Jan 9, 2017

Hello my fellow Rustaceans.
I have made the effort to translate the entire Rust website to italian.
The translation of the Rust website is complete

This is my first contribution ever to an open source project so please be kind

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

This is my first contribution ever to an open source project so please be kind

Looks great to me so far! However, due to some other changes, you'll need to rebase this before we can merge. I can absolutely help you with that if you need any.

@gabibbo97
Copy link
Contributor Author

Thanks @steveklabnik I should now have managed to get the branch to merge cleanly.

@steveklabnik
Copy link
Member

Great! Do you want me to merge this as-is, or do you have more work to do? You mentioned that you wanted to do at least one part in another PR...

@gabibbo97
Copy link
Contributor Author

Thanks for your help @steveklabnik, as I stated beforehand I would like to terminate the translation of the FAQ page before finally being merged, I will update this pull request with the final details probably around 20 CEST of the 12 of Jan because tomorrow I am attending two exams so I will probably be busy.

In the meanwhile I will ensure that the automatic merge can be performed without conflicts with the base branch and directly state its status of completeness in another comment.
After declaring the PR as ready you can be free to merge it as soon as you want.

After that I might try to still get involved into getting the Italian translation synced with the upstream en-US one.

Let's keep in touch for later, and thanks for your help!

@steveklabnik
Copy link
Member

I am attending two exams so I will probably be busy.

That's super okay, thank you so much for the work so far, and good luck on your exams! Just let me know when this is ready to ship 😄

@gabibbo97
Copy link
Contributor Author

Ok, sorry for the delay, now the translation is complete, including the FAQ page

@steveklabnik steveklabnik merged commit 594e56f into rust-lang:master Jan 16, 2017
@steveklabnik
Copy link
Member

Merged! Thanks 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants