Remove symmetries in the subset relation
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the clap dataset, there are: - Naive variant: subset (7531526) symmetries: 794833 Removing the symmetries results: from 36.7s to 33.2s (non-scientific benchmarks, best time) - DatafrogOpt variant: subset (2714121) symmetries: 481294 Removing the symmetries results: from 5.89s to 5.02s (non-scientific benchmarks, best time)
|
Hmm, hacky, but ... ok I guess. |
|
For the record, my preferred 3rd way of doing this would be to add methods with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the clap dataset, there are:
Naive variant: subset (7 531 526) symmetries: 794 833
Removing the symmetries results: from 36.7s to 33.2s (non-scientific benchmarks, best time)
DatafrogOpt variant: subset (2 714 121) symmetries: 481 294
Removing the symmetries results: from 5.89s to 5.02s (non-scientific benchmarks, best time)
This could be considered as fixing #62.
r? @nikomatsakis