Allow the output of a join to be filtered by an arbitrary predicate #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to eliminate reflexive subset relations in Polonius. Currently, we do this by manually filtering the
subset
relation at each stage, but this is inefficient and makes things a bit harder to reason about. This change allows us to write the equivalent of the following rule.The signature for
from_join_filtered
is maximally expressive, allowing the user to inspect the shared key and both values when deciding whether to filter. I think this is good, but it's possible there's a more restrictive API that would achieve the same thing?