Skip to content

Avoid panicking when Cargo.toml is not present #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+5 −1
Merged

Avoid panicking when Cargo.toml is not present #4643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cargo-miri/src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ fn cargo_extra_flags() -> Vec<String> {

pub fn get_cargo_metadata() -> Metadata {
// This will honor the `CARGO` env var the same way our `cargo()` does.
MetadataCommand::new().no_deps().other_options(cargo_extra_flags()).exec().unwrap()
MetadataCommand::new()
.no_deps()
.other_options(cargo_extra_flags())
.exec()
.unwrap_or_else(|err| show_error!("{}", err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this error look like?

I am wondering if we should add something like "cargo metadata failed:\n{}" or so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message currently looks like this:

fatal error: `cargo metadata` exited with an error: error: could not find `Cargo.toml` in `/home/ftg` or any parent directory

For a visual comparison, an image of the previous and current behavior is available below:

image

Apologies for not including this information when I initially opened the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And no worries. :)

That does sound a bit redundant, but the message seems to be entirely controlled by cargo_metadata, and it's definitely a big step up from before, so -- LGTM.

}

/// Pulls all the crates in this workspace from the cargo metadata.
Expand Down