Avoid panicking when Cargo.toml is not present
#4643
Conversation
|
Thank you for contributing to Miri! |
| .no_deps() | ||
| .other_options(cargo_extra_flags()) | ||
| .exec() | ||
| .unwrap_or_else(|err| show_error!("{}", err)) |
There was a problem hiding this comment.
What does this error look like?
I am wondering if we should add something like "cargo metadata failed:\n{}" or so.
There was a problem hiding this comment.
The error message currently looks like this:
fatal error: `cargo metadata` exited with an error: error: could not find `Cargo.toml` in `/home/ftg` or any parent directory
For a visual comparison, an image of the previous and current behavior is available below:
Apologies for not including this information when I initially opened the PR.
There was a problem hiding this comment.
Thanks! And no worries. :)
That does sound a bit redundant, but the message seems to be entirely controlled by cargo_metadata, and it's definitely a big step up from before, so -- LGTM.
3 participants
Hello!
This is my first contribution here to Miri, and hopefully the first of many! :)
When running
cargo clippyin a directory that does not contain aCargo.toml, it displays an informative message such as:could not find Cargo.toml in [dir] or any parent directory.In contrast, running
cargo miri [test|run]without aCargo.tomlcurrently causes a panic.While it is expected that this command should fail, a more user-friendly behavior, similar to
clippy, would be to print a descriptive error message instead of panicking.I'd appreciate your feedback on the following:
I was considering simply calling
bail!on the error, as done incargo(see here), but that would require addinganyhowas a dependency tocargo-miri. Since we already have ashow_error!macro available, I believe it might be better to use that instead.Thank you in advance for your time and input!