Skip to content

stdarch test: set STDARCH_TEST_EVERYTHING without leaking the whole host environment into the interpreted program #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024
+1 −3
Merged

stdarch test: set STDARCH_TEST_EVERYTHING without leaking the whole host environment into the interpreted program #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions run-stdarch-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ esac
export RUSTFLAGS="${RUSTFLAGS:-} $TARGET_RUSTFLAGS -Ainternal_features"

# Make sure all tested target features are enabled
export STDARCH_TEST_EVERYTHING=1
# Needed to pass the STDARCH_TEST_EVERYTHING environment variable
export MIRIFLAGS="${MIRIFLAGS:-} -Zmiri-disable-isolation"
Copy link
Member

@RalfJung RalfJung Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW you could have used -Zmiri-env-forward=STDARCH_TEST_EVERYTHING, that would also not have leaked the whole host environment, only that one variable.

export MIRIFLAGS="${MIRIFLAGS:-} -Zmiri-env-set=STDARCH_TEST_EVERYTHING=1"

# Set library source dir
export MIRI_LIB_SRC=${MIRI_LIB_SRC:-$(rustc --print sysroot)/lib/rustlib/src/rust/library}
Expand Down