stdarch test: set STDARCH_TEST_EVERYTHING without leaking the whole host environment into the interpreted program #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost environment into the interpreted program
RalfJung
reviewed
Apr 30, 2024
| # Make sure all tested target features are enabled | ||
| export STDARCH_TEST_EVERYTHING=1 | ||
| # Needed to pass the STDARCH_TEST_EVERYTHING environment variable | ||
| export MIRIFLAGS="${MIRIFLAGS:-} -Zmiri-disable-isolation" |
Member
There was a problem hiding this comment.
FWIW you could have used -Zmiri-env-forward=STDARCH_TEST_EVERYTHING, that would also not have leaked the whole host environment, only that one variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.