Skip to content

Use claim to simplify assertions #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Use claim to simplify assertions #2962

merged 1 commit into from
Oct 31, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 26, 2020

This PR introduces https://github.com/svartalf/rust-claim/ for our tests to replace our custom t!() macro and simplify/improve a few other assert!() usages.

t!() is certainly shorter than assert_ok!(), but I think the latter expresses the intent way better than the former. With t!() is was always thinking that this might have something to do with translations... 😅

r? @jtgeibel

@bors
Copy link
Contributor

bors commented Oct 28, 2020

☔ The latest upstream changes (presumably #2954) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors
Copy link
Contributor

bors commented Oct 29, 2020

☔ The latest upstream changes (presumably #2946) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@jtgeibel
Copy link
Member

I especially like assert_some_eq!, LGTM!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2020

📌 Commit 03ad28b has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Oct 31, 2020

⌛ Testing commit 03ad28b with merge 30bf5bd...

@bors
Copy link
Contributor

bors commented Oct 31, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 30bf5bd to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants