Remove turbofishes from diesel calls #2946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
turbo-fish
branch
3 times, most recently
from
185a61c to
69c577f
Compare
This makes the code a little more readable and helps `intellij-rust` in understanding the types of the variables
This makes the code a little more readable and helps `intellij-rust` in understanding the types of the variables
This makes the code a little more readable and helps `intellij-rust` in understanding the types of the variables
This makes the code a little more readable and helps `intellij-rust` in understanding the types of the variables
|
I poked around a little bit with rust-analyzer and don't see any regressions in type inference there. In a few of these cases I like the turbofish version a bit more, but consistency and good IDE experiences seems more important. @bors r+ |
|
📌 Commit 4a20e53 has been approved by |
|
☀️ Test successful - checks-travis |
This was referenced Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code a little more readable and helps e.g.
intellij-rustin understanding the types of the variables betterr? @jtgeibel