-
Notifications
You must be signed in to change notification settings - Fork 2.7k
refactor(timings): separate data collection and presentation #16282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,170
−1,101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cafc37d to
b28eb02
Compare
epage
reviewed
Nov 20, 2025
epage
reviewed
Nov 20, 2025
epage
reviewed
Nov 20, 2025
Don't access an shell or file system in render reporting module.
b28eb02 to
ae9beb9
Compare
Member
Author
|
We probably have seen this on Windows aarch64 MSVC stable? (I totally forgot) https://github.com/rust-lang/cargo/actions/runs/19555803247/job/55997837387#step:15:4835 |
epage
approved these changes
Nov 21, 2025
This was referenced Nov 21, 2025
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2025
Update cargo submodule 7 commits in 5c0343317ce45d2ec17ecf41eaa473a02d73e29c..9fa462fe3a81e07e0bfdcc75c29d312c55113ebb 2025-11-18 19:05:44 +0000 to 2025-11-21 20:49:51 +0000 - Enable CARGO_CFG_DEBUG_ASSERTIONS in build scripts based on profile (rust-lang/cargo#16160) - fix(config-include): disallow glob and template syntax (rust-lang/cargo#16285) - test(config-include): include always relative to including config (rust-lang/cargo#16286) - docs(guide): When suggesting alt dev profile, link to related issue (rust-lang/cargo#16275) - refactor(timings): separate data collection and presentation (rust-lang/cargo#16282) - test(build-std): Add test for LTO (rust-lang/cargo#16277) - fix(bindeps): do not propagate artifact dependency to proc macro or build deps (rust-lang/cargo#15788) r? ghost
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-build-execution
Area: anything dealing with executing the compiler
A-infrastructure
Area: infrastructure around the cargo repo, ci, releases, etc.
A-timings
Area: timings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The goal of this refactor is to separate data collection and presentation,
so that we can replay an HTML report from log generated by
-Zbuild-analysis.Part of #15844
How to test and review this PR?
Should have no user-facing change,
though I would encourage review to run
cargo build --timingsand check if there is anything broken.