Skip to content

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Nov 20, 2025

What does this PR try to resolve?

The goal of this refactor is to separate data collection and presentation,
so that we can replay an HTML report from log generated by -Zbuild-analysis.

Part of #15844

How to test and review this PR?

Should have no user-facing change,
though I would encourage review to run cargo build --timings
and check if there is anything broken.

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-timings Area: timings S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@weihanglo weihanglo added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. labels Nov 20, 2025
@weihanglo
Copy link
Member Author

We probably have seen this on Windows aarch64 MSVC stable? (I totally forgot)

https://github.com/rust-lang/cargo/actions/runs/19555803247/job/55997837387#step:15:4835

thread 'registry::sparse_blocking_count' (1028) panicked at tests\testsuite\registry.rs:3587:7:

---- expected: tests\testsuite\registry.rs:3572:27
++++ actual:   stderr
   1      -    [..] TRACE network::HttpRegistry::block_until_ready: 0 transfers pending
        1 +   11.521002200s TRACE network::HttpRegistry::block_until_ready: 0 transfers pending
   2    2 | [UPDATING] `dummy-registry` index
   3      -    [..] TRACE network::HttpRegistry::block_until_ready: 1 transfers pending
   4      -    [..] TRACE network::HttpRegistry::block_until_ready: 1 transfers pending
        3 +   11.522428200s TRACE network::HttpRegistry::block_until_ready: 1 transfers pending
        4 +   11.526991600s TRACE network::HttpRegistry::block_until_ready: 1 transfers pending
   5    5 | [WARNING] spurious network error (3 tries remaining): failed to get successful HTTP response from `[..]/index/3/b/bar` ([..]), got 500
   6    6 | body:
   7    7 | internal server error
   8    8 | [LOCKING] 1 package to latest compatible version
   9    9 | [DOWNLOADING] crates ...
  10   10 | [DOWNLOADED] bar v0.0.1 (registry `dummy-registry`)
  11   11 | [CHECKING] bar v0.0.1
  12   12 | [CHECKING] foo v0.0.1 ([ROOT]/foo)
  13   13 | [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

@epage epage added this pull request to the merge queue Nov 21, 2025
Merged via the queue into rust-lang:master with commit 6ed260f Nov 21, 2025
45 of 52 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2025
@weihanglo weihanglo deleted the timing-refactor branch November 21, 2025 04:56
bors added a commit to rust-lang/rust that referenced this pull request Nov 22, 2025
Update cargo submodule

7 commits in 5c0343317ce45d2ec17ecf41eaa473a02d73e29c..9fa462fe3a81e07e0bfdcc75c29d312c55113ebb
2025-11-18 19:05:44 +0000 to 2025-11-21 20:49:51 +0000
- Enable CARGO_CFG_DEBUG_ASSERTIONS in build scripts based on profile (rust-lang/cargo#16160)
- fix(config-include): disallow glob and template syntax (rust-lang/cargo#16285)
- test(config-include): include always relative to including config (rust-lang/cargo#16286)
- docs(guide): When suggesting alt dev profile, link to related issue (rust-lang/cargo#16275)
- refactor(timings): separate data collection and presentation (rust-lang/cargo#16282)
- test(build-std): Add test for LTO (rust-lang/cargo#16277)
- fix(bindeps): do not propagate artifact dependency to proc macro or build deps (rust-lang/cargo#15788)

r? ghost
@rustbot rustbot added this to the 1.93.0 milestone Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-build-execution Area: anything dealing with executing the compiler A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-timings Area: timings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants