Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Nov 18, 2025

What does this PR try to resolve?

Having sections in the build performance chapter link out to their issues is helpful for:

  • giving hope that things will improve
  • providing a place for people to subscribe to for updates
  • raise visibility for ensuring we get appropriaet feedback (e.g. on degrading the debugger experience)

Noticed this was missing while writing up about this new chapter on the blog post.

How to test and review this PR?

Having sections in the build performance chapter link out to their
issues is helpful for:
- giving hope that things will improve
- providing a place for people to subscribe to for updates
- raise visibility for ensuring we get appropriaet feedback (e.g. on
  degrading the debugger experience)

Noticed this was missing while writing up about this new chapter on the
blog post.
@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@weihanglo
Copy link
Member

"Tests Windows x86_64 gnu nightly" stack overflow: rust-lang/rust#139070

https://github.com/rust-lang/cargo/actions/runs/19479373309/job/55747288407?pr=16275#step:15:4742

 ---- profile_trim_paths::custom_build_env_var_trim_paths stdout ----
running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`
running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`
running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`
running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`
running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`

thread 'profile_trim_paths::custom_build_env_var_trim_paths' (2472) panicked at tests\testsuite\profile_trim_paths.rs:768:14:

test failed running `D:\a\cargo\cargo\target\debug\cargo.exe build -Ztrim-paths`
error: process exited with code 101 (expected 0)
--- stdout

--- stderr
   Compiling foo v0.0.1 (D:\a\cargo\cargo\target\tmp\cit\t2830\foo)

thread 'main' (10124) has overflowed its stack
error: could not compile `foo` (lib)

Caused by:
  process didn't exit successfully: `rustc --crate-name foo --edition=2015 src\lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --check-cfg cfg(docsrs,test) --check-cfg "cfg(feature, values())" -C metadata=9dd8a03acaba44eb -C extra-filename=-60a15610e42c1955 --out-dir D:\a\cargo\cargo\target\tmp\cit\t2830\foo\target\debug\deps -L dependency=D:\a\cargo\cargo\target\tmp\cit\t2830\foo\target\debug\deps` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)cit\t2830\foo\target\debug\deps` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@weihanglo weihanglo added this pull request to the merge queue Nov 21, 2025
Merged via the queue into rust-lang:master with commit f3b7ff7 Nov 21, 2025
26 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2025
@epage epage deleted the guide branch November 21, 2025 17:50
bors added a commit to rust-lang/rust that referenced this pull request Nov 22, 2025
Update cargo submodule

7 commits in 5c0343317ce45d2ec17ecf41eaa473a02d73e29c..9fa462fe3a81e07e0bfdcc75c29d312c55113ebb
2025-11-18 19:05:44 +0000 to 2025-11-21 20:49:51 +0000
- Enable CARGO_CFG_DEBUG_ASSERTIONS in build scripts based on profile (rust-lang/cargo#16160)
- fix(config-include): disallow glob and template syntax (rust-lang/cargo#16285)
- test(config-include): include always relative to including config (rust-lang/cargo#16286)
- docs(guide): When suggesting alt dev profile, link to related issue (rust-lang/cargo#16275)
- refactor(timings): separate data collection and presentation (rust-lang/cargo#16282)
- test(build-std): Add test for LTO (rust-lang/cargo#16277)
- fix(bindeps): do not propagate artifact dependency to proc macro or build deps (rust-lang/cargo#15788)

r? ghost
@rustbot rustbot added this to the 1.93.0 milestone Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-documenting-cargo-itself Area: Cargo's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants